[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)

[GitBox <gi...@apache.org>]

franz1981 edited a comment on issue #2845: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file (AGAIN)
URL: https://github.com/apache/activemq-artemis/pull/2845#issuecomment-547052727
 
 
   @wy96f 
   One quick question: on https://github.com/apache/activemq-artemis/pull/2845#issuecomment-535440070 I see that you've said:
   > with -Dio.netty.file.region=true or master
   
   But actually master and  `-Dio.netty.file.region=true` are very different!
   master has the feature with zero copy not enabled and `ByteBuf` are correctly estimated, while  `-Dio.netty.file.region=true` on this PR is using custom `FileRegion`s that doesn't seems correctly estimated according to https://github.com/netty/netty/blob/ff7a9fa091a8bf2e10020f83fc4df1c44098bbbb/transport/src/main/java/io/netty/channel/DefaultMessageSizeEstimator.java#L45.
   In theory `-Dio.netty.file.region=true` should time out due to the wrong estimation (like `-Dio.netty.file.region=false`): do you have tested `-Dio.netty.file.region=true` on this PR with your long replication backlog test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services