[GitHub] [flink] xintongsong commented on pull request #18409: [hotfix][dist] Fix that flink-gs-fs-hadoop not included in flink-dist

[GitBox <gi...@apache.org>]

xintongsong commented on pull request #18409:
URL: https://github.com/apache/flink/pull/18409#issuecomment-1019892373


   Adding `flink-gs-fs-hadoop` as a provided-scope dependency of `flink-dist`, I'm again running into the grpc version issue.
   https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=29771&view=logs&j=bea52777-eaf8-5663-8482-18fbc3630e81&t=d6e79740-7cf7-5407-2e69-ca34c9be0efb&l=29490
   
   Note that the errors came from the javadoc check (`mvn javadoc:aggregate`), which is after successfully building the project. It seems to me `dependencyManagement` in `flink-gs-fs-hadoop` is not taking effect in running `mvn javadoc:aggregate` for the whole project. I don't know the reason.
   
   Moving the grpc dependency management to `flink-parent` fixes the problem. However, that means the grpc version applies to the entire project, instead of only the `flink-gs-fs-hadoop` module. Although the CI does not show any problem, I'm not entirely sure about this.
   
   WDYT? cc @galenwarren @zentol 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org