[GitHub] [hive] wecharyu commented on a diff in pull request #4150: HIVE-27172: Add the HMS client connection timeout config

["wecharyu (via GitHub)" <gi...@apache.org>]

wecharyu commented on code in PR #4150:
URL: https://github.com/apache/hive/pull/4150#discussion_r1147927316


##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java:
##########
@@ -43,9 +46,10 @@ public class TestHiveMetaStoreTimeout {
   protected static HiveMetaStoreClient client;
   protected static Configuration conf;
   protected static Warehouse warehouse;
+  protected static int port;
 
-  @BeforeClass
-  public static void setUp() throws Exception {
+  @Before
+  public void setUp() throws Exception {
     HMSHandler.testTimeoutEnabled = true;

Review Comment:
   Nit: This test code hacks `HMSHandler` class, I will refactor this in a new PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org