You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/10 08:45:33 UTC
[GitHub] [apisix] RocFang opened a new pull request #2376: fix: wget -O always leave a file enven though download fail
RocFang opened a new pull request #2376:
URL: https://github.com/apache/apisix/pull/2376
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
wget always leave a file, enven though error happens when download.
So it's maybe not proper to decide wether to download a new file by checking the file's existence.
### Pre-submission checklist:
* [ x ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ x ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #2376: fix: wget -O always leave a file enven though download fail
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2376:
URL: https://github.com/apache/apisix/pull/2376#issuecomment-706522126
`-P` will not leave a file? @RocFang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] RocFang edited a comment on pull request #2376: fix: wget -O always leave a file enven though download fail
Posted by GitBox <gi...@apache.org>.
RocFang edited a comment on pull request #2376:
URL: https://github.com/apache/apisix/pull/2376#issuecomment-706523699
we can also check if the file's size is zero,
but i think wget -P is easier:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] RocFang edited a comment on pull request #2376: fix: wget -O always leave a file enven though download fail
Posted by GitBox <gi...@apache.org>.
RocFang edited a comment on pull request #2376:
URL: https://github.com/apache/apisix/pull/2376#issuecomment-706523141
@moonming yes, that's right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #2376: fix: wget -O always leave a file enven though download fail
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2376:
URL: https://github.com/apache/apisix/pull/2376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] RocFang edited a comment on pull request #2376: fix: wget -O always leave a file enven though download fail
Posted by GitBox <gi...@apache.org>.
RocFang edited a comment on pull request #2376:
URL: https://github.com/apache/apisix/pull/2376#issuecomment-706524157
for some reason we know, raw.githubusercontent.com can't accessed normally,
when it fail, the error message get confusing when you try next time because of the zero size file the last wget command left there.
and that's how i found this problem. @moonming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] RocFang edited a comment on pull request #2376: fix: wget -O always leave a file enven though download fail
Posted by GitBox <gi...@apache.org>.
RocFang edited a comment on pull request #2376:
URL: https://github.com/apache/apisix/pull/2376#issuecomment-706523141
@moonming yes.
As we know in mainland china, raw.githubusercontent.com is blocked. it's easy to test it by close your proxy/vpn, and then delete util/lj-relang and try to make lint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] RocFang edited a comment on pull request #2376: fix: wget -O always leave a file enven though download fail
Posted by GitBox <gi...@apache.org>.
RocFang edited a comment on pull request #2376:
URL: https://github.com/apache/apisix/pull/2376#issuecomment-706524157
for some reason we know, raw.githubusercontent.com can't accessed normally,
when it fail, the error message get confusing when you try next time for the zero size file the last wget command left there.
and that's how i found this problem. @moonming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] RocFang commented on pull request #2376: fix: wget -O always leave a file enven though download fail
Posted by GitBox <gi...@apache.org>.
RocFang commented on pull request #2376:
URL: https://github.com/apache/apisix/pull/2376#issuecomment-706523699
we can also check if the file's size if zero,
but i think wget -P is easier:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming edited a comment on pull request #2376: fix: wget -O always leave a file enven though download fail
Posted by GitBox <gi...@apache.org>.
moonming edited a comment on pull request #2376:
URL: https://github.com/apache/apisix/pull/2376#issuecomment-706522126
`-P` will not leave a file when download fail? @RocFang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] RocFang commented on pull request #2376: fix: wget -O always leave a file enven though download fail
Posted by GitBox <gi...@apache.org>.
RocFang commented on pull request #2376:
URL: https://github.com/apache/apisix/pull/2376#issuecomment-706524157
for some reason we know, raw.githubusercontent.com can't accessed normally,
when it fail, the error message get confusing when you try next time for the zero size file the last wget command left there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] RocFang commented on pull request #2376: fix: wget -O always leave a file enven though download fail
Posted by GitBox <gi...@apache.org>.
RocFang commented on pull request #2376:
URL: https://github.com/apache/apisix/pull/2376#issuecomment-706523141
@moonming yes.
As we know in mainland china, raw.githubusercontent.com is blocked. it's easy to test it by close your proxy/vpn, and then delete util/lj-relang and try make lint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org