[GitHub] [doris] yiguolei commented on a diff in pull request #10717: [refactor] remove PredicateColumn

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #10717:
URL: https://github.com/apache/doris/pull/10717#discussion_r917335252


##########
be/src/olap/rowset/segment_v2/bitshuffle_page.h:
##########
@@ -392,7 +392,14 @@ class BitShufflePageDecoder : public PageDecoder {
 
         size_t max_fetch = std::min(*n, static_cast<size_t>(_num_elements - _cur_index));
 
-        dst->insert_many_fix_len_data(get_data(_cur_index), max_fetch);
+        // todo(wb) remove this branch after the data format is completely unified
+        if constexpr (Type == OLAP_FIELD_TYPE_DATE) {
+            dst->insert_many_date(get_data(_cur_index), max_fetch);
+        } else if constexpr (Type == OLAP_FIELD_TYPE_DATETIME) {

Review Comment:
   我倾向在 column 中做这种判断，比如我们可以调用insert fixed length data， 但是在这个函数里我们判断一下column的类型，做if else 判断



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org