You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/08/29 09:24:57 UTC
[GitHub] [spark] itholic opened a new pull request, #42719: [SPARK-45005][CONNECT][PS][TESTS] Reducing the CI time by splitting the slow tests
itholic opened a new pull request, #42719:
URL: https://github.com/apache/spark/pull/42719
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to reduce the CI time for `pyspark-pandas-connect` by splitting the slow tests.
This PR basically:
- Split `pyspark-pandas-slow-connect` into two parts.
- Move couple of slow tests into `pyspark-pandas-slow-connect-part2`
- Split the existing tests into several parts, and move into `pyspark-pandas-slow-connect-part2`
### Why are the changes needed?
`pyspark-pandas-connect` test takes more than 3 hours in Github Actions, so we might need to reduce the execution time. See https://github.com/apache/spark/actions/runs/5989124806/job/16245001034 as an example.
<img width="516" alt="Screenshot 2023-08-29 at 6 20 41 PM" src="https://github.com/apache/spark/assets/44108233/17f6e21a-3c72-4421-a924-712828171e26">
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No, it's test-only.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Manually tested, and the actual testing time should be reduced form Github Actions CI when it's done.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42719: [WIP][SPARK-45005][CONNECT][PS][TESTS] Reducing the CI time by splitting the slow tests
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42719:
URL: https://github.com/apache/spark/pull/42719#discussion_r1309680207
##########
python/pyspark/pandas/tests/indexes/test_datetime.py:
##########
@@ -271,6 +271,12 @@ def test_map(self):
class DatetimeIndexTests(DatetimeIndexTestsMixin, PandasOnSparkTestCase, TestUtils):
+ def test_properties(self):
+ super(DatetimeIndexTests, self).test_properties()
+
+ def test_indexer_between_time(self):
+ super(DatetimeIndexTests, self).test_indexer_between_time()
+
pass
Review Comment:
let's remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #42719: [WIP][SPARK-45005][CONNECT][PS][TESTS] Reducing the CI time by splitting the slow tests
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #42719:
URL: https://github.com/apache/spark/pull/42719#discussion_r1309572603
##########
.github/workflows/build_and_test.yml:
##########
@@ -367,7 +367,9 @@ jobs:
- >-
pyspark-pandas-connect
Review Comment:
totally nit: to be consistent, what about:
```
pyspark-pandas-connect-part0
pyspark-pandas-connect-part1
pyspark-pandas-connect-part2
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42719: [SPARK-45005][CONNECT][PS][TESTS] Reducing the CI time by splitting the slow tests
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42719:
URL: https://github.com/apache/spark/pull/42719#discussion_r1324424399
##########
.github/workflows/build_and_test.yml:
##########
@@ -365,9 +365,11 @@ jobs:
- >-
pyspark-connect
- >-
- pyspark-pandas-connect
+ pyspark-pandas-connect-part0
- >-
- pyspark-pandas-slow-connect
+ pyspark-pandas-connect-part1
Review Comment:
@itholic can you rebalance this? This test alone takes 3 hours while others all finish within 2 hours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #42719: [WIP][SPARK-45005][CONNECT][PS][TESTS] Reducing the CI time by splitting the slow tests
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #42719:
URL: https://github.com/apache/spark/pull/42719#discussion_r1309586251
##########
.github/workflows/build_and_test.yml:
##########
@@ -367,7 +367,9 @@ jobs:
- >-
pyspark-pandas-connect
Review Comment:
Renamed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #42719: [SPARK-45005][CONNECT][PS][TESTS] Reducing the CI time by splitting the slow tests
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #42719:
URL: https://github.com/apache/spark/pull/42719#issuecomment-1699572389
Thanks everyone for the review! Seems like the testing time now have some balance as below:
**Before**
|pyspark-pandas-connect|pyspark-pandas-slow-connect|
|--|--|
|3h 48m|2h 48m|
**After**
|pyspark-pandas-connect-part0|pyspark-pandas-connect-part1|pyspark-pandas-connect-part2|
|--|--|--|
|1h 51m|2h 55m|1h 54m|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42719: [SPARK-45005][CONNECT][PS][TESTS] Reducing the CI time by splitting the slow tests
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42719: [SPARK-45005][CONNECT][PS][TESTS] Reducing the CI time by splitting the slow tests
URL: https://github.com/apache/spark/pull/42719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42719: [WIP][SPARK-45005][CONNECT][PS][TESTS] Reducing the CI time by splitting the slow tests
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42719:
URL: https://github.com/apache/spark/pull/42719#discussion_r1309679997
##########
python/pyspark/pandas/tests/connect/test_parity_frame_interpolate.py:
##########
@@ -0,0 +1,39 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+import unittest
+
+from pyspark.pandas.tests.test_frame_interpolate import FrameInterpolateTestsMixin
+from pyspark.testing.connectutils import ReusedConnectTestCase
+from pyspark.testing.pandasutils import PandasOnSparkTestUtils, TestUtils
+
+
+class FrameInterpolateParityTests(
+ FrameInterpolateTestsMixin, TestUtils, PandasOnSparkTestUtils, ReusedConnectTestCase
+):
+ pass
+
+
+if __name__ == "__main__":
+ from pyspark.pandas.tests.connect.test_parity_generic_functions import * # noqa: F401
Review Comment:
should fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #42719: [SPARK-45005][CONNECT][PS][TESTS] Reducing the CI time by splitting the slow tests
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #42719:
URL: https://github.com/apache/spark/pull/42719#discussion_r1324566787
##########
.github/workflows/build_and_test.yml:
##########
@@ -365,9 +365,11 @@ jobs:
- >-
pyspark-connect
- >-
- pyspark-pandas-connect
+ pyspark-pandas-connect-part0
- >-
- pyspark-pandas-slow-connect
+ pyspark-pandas-connect-part1
Review Comment:
Open a PR here: https://github.com/apache/spark/pull/42909
Let's see if it's balanced well :-)
##########
.github/workflows/build_and_test.yml:
##########
@@ -365,9 +365,11 @@ jobs:
- >-
pyspark-connect
- >-
- pyspark-pandas-connect
+ pyspark-pandas-connect-part0
- >-
- pyspark-pandas-slow-connect
+ pyspark-pandas-connect-part1
Review Comment:
Opened a PR here: https://github.com/apache/spark/pull/42909
Let's see if it's balanced well :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org