You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/10/14 09:57:55 UTC

[GitHub] [flink] hequn8128 commented on a change in pull request #9886: [FLINK-14027][python][doc] Add documentation for Python user-defined functions.

hequn8128 commented on a change in pull request #9886: [FLINK-14027][python][doc] Add documentation for Python user-defined functions.
URL: https://github.com/apache/flink/pull/9886#discussion_r334372170
 
 

 ##########
 File path: docs/dev/table/udfs.md
 ##########
 @@ -112,50 +152,54 @@ public class HashCode extends ScalarFunction {
 }
 '''
 
+class HashCode(ScalarFunction):
 
 Review comment:
   The class name is same with the java class name, i.e., both called `HashCode`. How about give it a different name to avoid confusions? 
   Users may confused when seeing the `HashCode` in `table_env.register_java_function("hashCode", "my.java.function.HashCode")`.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services