You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Glen Mazza (JIRA)" <ji...@apache.org> on 2007/07/26 14:53:41 UTC
[jira] Issue Comment Edited: (CXF-803) Configuring interceptors
using annotations
[ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515646 ]
Glen Mazza edited comment on CXF-803 at 7/26/07 5:53 AM:
---------------------------------------------------------
Looks good! But will the committer of this patch please fix the constant in initializeAnnotationObjects() from COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
Glen
was:
Looks good! But please fix the constant in initializeAnnotationObjects() from COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
Glen
> Configuring interceptors using annotations
> ------------------------------------------
>
> Key: CXF-803
> URL: https://issues.apache.org/jira/browse/CXF-803
> Project: CXF
> Issue Type: New Feature
> Components: Configuration
> Affects Versions: 2.0
> Environment: All
> Reporter: Zarar Siddiqi
> Attachments: cxf-803-2.patch, cxf-803.patch
>
>
> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
> Thanks,
> Zarar
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Issue Comment Edited: (CXF-803) Configuring interceptors
using annotations
Posted by "Jeff.Yu" <je...@iona.com>.
ok... got it, thanks for your clarification.
Thanks
Jeff
Daniel Kulp wrote:
> Jeff,
>
> He was just commenting that you spelled INTERCEPTOR wrong.... In your
> original patch, it was INTERCEPOTR (check the last three letters).
> The comment doesn't apply since you changed it.
>
> Dan
>
>
> On Thursday 26 July 2007 22:29, Jeff.Yu wrote:
>
>> Hi, Glen
>>
>> What do you mean by changing constant from
>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR, because
>> in the initializeAnnotationObjects() method, it might be
>> "InInterceptor, OutInterceptor,InFaultInterceptor, AbstractFeature"
>> etc, and I don't think we need to specify it so detail within a quite
>> generic method. BTW, I changed the
>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to
>> COULD_NOT_CREATE_ANNOTATION_OBJECT in last patch, since it might be
>> FEATURES not INTERCEPTOR.
>>
>>
>>
>> Thanks
>> Jeff Yu
>>
>> Glen Mazza (JIRA) wrote:
>>
>>> [
>>> https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jir
>>> a.plugin.system.issuetabpanels:comment-tabpanel#action_12515646 ]
>>>
>>> Glen Mazza edited comment on CXF-803 at 7/26/07 5:53 AM:
>>> ---------------------------------------------------------
>>>
>>> Looks good! But will the committer of this patch please fix the
>>> constant in initializeAnnotationObjects() from
>>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
>>>
>>> Glen
>>>
>>>
>>>
>>> was:
>>> Looks good! But please fix the constant in
>>> initializeAnnotationObjects() from
>>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
>>>
>>> Glen
>>>
>>>
>>>> Configuring interceptors using annotations
>>>> ------------------------------------------
>>>>
>>>> Key: CXF-803
>>>> URL: https://issues.apache.org/jira/browse/CXF-803
>>>> Project: CXF
>>>> Issue Type: New Feature
>>>> Components: Configuration
>>>> Affects Versions: 2.0
>>>> Environment: All
>>>> Reporter: Zarar Siddiqi
>>>> Attachments: cxf-803-2.patch, cxf-803.patch
>>>>
>>>>
>>>> It would be helpful to configure interceptors using annotations.
>>>> CXF would benefit by having annotations similar to XFire's
>>>> org.codehaus.xfire.annotations.InHandlers and
>>>> org.codehaus.xfire.annotations.OutHandlers as it would allow
>>>> specifying specific interceptors for service implementations. This
>>>> issue came up on the mailing list:
>>>> http://www.nabble.com/Configuring-interceptors-using-annotations-tf
>>>> 4097300.html Thanks,
>>>> Zarar
>>>>
>
>
Re: [jira] Issue Comment Edited: (CXF-803) Configuring interceptors
using annotations
Posted by "Jeff.Yu" <je...@iona.com>.
ok... got it, thanks for your clarification.
Thanks
Jeff
Daniel Kulp wrote:
> Jeff,
>
> He was just commenting that you spelled INTERCEPTOR wrong.... In your
> original patch, it was INTERCEPOTR (check the last three letters).
> The comment doesn't apply since you changed it.
>
> Dan
>
>
> On Thursday 26 July 2007 22:29, Jeff.Yu wrote:
>
>> Hi, Glen
>>
>> What do you mean by changing constant from
>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR, because
>> in the initializeAnnotationObjects() method, it might be
>> "InInterceptor, OutInterceptor,InFaultInterceptor, AbstractFeature"
>> etc, and I don't think we need to specify it so detail within a quite
>> generic method. BTW, I changed the
>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to
>> COULD_NOT_CREATE_ANNOTATION_OBJECT in last patch, since it might be
>> FEATURES not INTERCEPTOR.
>>
>>
>>
>> Thanks
>> Jeff Yu
>>
>> Glen Mazza (JIRA) wrote:
>>
>>> [
>>> https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jir
>>> a.plugin.system.issuetabpanels:comment-tabpanel#action_12515646 ]
>>>
>>> Glen Mazza edited comment on CXF-803 at 7/26/07 5:53 AM:
>>> ---------------------------------------------------------
>>>
>>> Looks good! But will the committer of this patch please fix the
>>> constant in initializeAnnotationObjects() from
>>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
>>>
>>> Glen
>>>
>>>
>>>
>>> was:
>>> Looks good! But please fix the constant in
>>> initializeAnnotationObjects() from
>>> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
>>>
>>> Glen
>>>
>>>
>>>> Configuring interceptors using annotations
>>>> ------------------------------------------
>>>>
>>>> Key: CXF-803
>>>> URL: https://issues.apache.org/jira/browse/CXF-803
>>>> Project: CXF
>>>> Issue Type: New Feature
>>>> Components: Configuration
>>>> Affects Versions: 2.0
>>>> Environment: All
>>>> Reporter: Zarar Siddiqi
>>>> Attachments: cxf-803-2.patch, cxf-803.patch
>>>>
>>>>
>>>> It would be helpful to configure interceptors using annotations.
>>>> CXF would benefit by having annotations similar to XFire's
>>>> org.codehaus.xfire.annotations.InHandlers and
>>>> org.codehaus.xfire.annotations.OutHandlers as it would allow
>>>> specifying specific interceptors for service implementations. This
>>>> issue came up on the mailing list:
>>>> http://www.nabble.com/Configuring-interceptors-using-annotations-tf
>>>> 4097300.html Thanks,
>>>> Zarar
>>>>
>
>
Re: [jira] Issue Comment Edited: (CXF-803) Configuring interceptors using annotations
Posted by Daniel Kulp <dk...@apache.org>.
Jeff,
He was just commenting that you spelled INTERCEPTOR wrong.... In your
original patch, it was INTERCEPOTR (check the last three letters).
The comment doesn't apply since you changed it.
Dan
On Thursday 26 July 2007 22:29, Jeff.Yu wrote:
> Hi, Glen
>
> What do you mean by changing constant from
> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR, because
> in the initializeAnnotationObjects() method, it might be
> "InInterceptor, OutInterceptor,InFaultInterceptor, AbstractFeature"
> etc, and I don't think we need to specify it so detail within a quite
> generic method. BTW, I changed the
> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to
> COULD_NOT_CREATE_ANNOTATION_OBJECT in last patch, since it might be
> FEATURES not INTERCEPTOR.
>
>
>
> Thanks
> Jeff Yu
>
> Glen Mazza (JIRA) wrote:
> > [
> > https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jir
> >a.plugin.system.issuetabpanels:comment-tabpanel#action_12515646 ]
> >
> > Glen Mazza edited comment on CXF-803 at 7/26/07 5:53 AM:
> > ---------------------------------------------------------
> >
> > Looks good! But will the committer of this patch please fix the
> > constant in initializeAnnotationObjects() from
> > COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
> >
> > Glen
> >
> >
> >
> > was:
> > Looks good! But please fix the constant in
> > initializeAnnotationObjects() from
> > COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
> >
> > Glen
> >
> >> Configuring interceptors using annotations
> >> ------------------------------------------
> >>
> >> Key: CXF-803
> >> URL: https://issues.apache.org/jira/browse/CXF-803
> >> Project: CXF
> >> Issue Type: New Feature
> >> Components: Configuration
> >> Affects Versions: 2.0
> >> Environment: All
> >> Reporter: Zarar Siddiqi
> >> Attachments: cxf-803-2.patch, cxf-803.patch
> >>
> >>
> >> It would be helpful to configure interceptors using annotations.
> >> CXF would benefit by having annotations similar to XFire's
> >> org.codehaus.xfire.annotations.InHandlers and
> >> org.codehaus.xfire.annotations.OutHandlers as it would allow
> >> specifying specific interceptors for service implementations. This
> >> issue came up on the mailing list:
> >> http://www.nabble.com/Configuring-interceptors-using-annotations-tf
> >>4097300.html Thanks,
> >> Zarar
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog
Re: [jira] Issue Comment Edited: (CXF-803) Configuring interceptors using annotations
Posted by Daniel Kulp <dk...@apache.org>.
Jeff,
He was just commenting that you spelled INTERCEPTOR wrong.... In your
original patch, it was INTERCEPOTR (check the last three letters).
The comment doesn't apply since you changed it.
Dan
On Thursday 26 July 2007 22:29, Jeff.Yu wrote:
> Hi, Glen
>
> What do you mean by changing constant from
> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR, because
> in the initializeAnnotationObjects() method, it might be
> "InInterceptor, OutInterceptor,InFaultInterceptor, AbstractFeature"
> etc, and I don't think we need to specify it so detail within a quite
> generic method. BTW, I changed the
> COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to
> COULD_NOT_CREATE_ANNOTATION_OBJECT in last patch, since it might be
> FEATURES not INTERCEPTOR.
>
>
>
> Thanks
> Jeff Yu
>
> Glen Mazza (JIRA) wrote:
> > [
> > https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jir
> >a.plugin.system.issuetabpanels:comment-tabpanel#action_12515646 ]
> >
> > Glen Mazza edited comment on CXF-803 at 7/26/07 5:53 AM:
> > ---------------------------------------------------------
> >
> > Looks good! But will the committer of this patch please fix the
> > constant in initializeAnnotationObjects() from
> > COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
> >
> > Glen
> >
> >
> >
> > was:
> > Looks good! But please fix the constant in
> > initializeAnnotationObjects() from
> > COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
> >
> > Glen
> >
> >> Configuring interceptors using annotations
> >> ------------------------------------------
> >>
> >> Key: CXF-803
> >> URL: https://issues.apache.org/jira/browse/CXF-803
> >> Project: CXF
> >> Issue Type: New Feature
> >> Components: Configuration
> >> Affects Versions: 2.0
> >> Environment: All
> >> Reporter: Zarar Siddiqi
> >> Attachments: cxf-803-2.patch, cxf-803.patch
> >>
> >>
> >> It would be helpful to configure interceptors using annotations.
> >> CXF would benefit by having annotations similar to XFire's
> >> org.codehaus.xfire.annotations.InHandlers and
> >> org.codehaus.xfire.annotations.OutHandlers as it would allow
> >> specifying specific interceptors for service implementations. This
> >> issue came up on the mailing list:
> >> http://www.nabble.com/Configuring-interceptors-using-annotations-tf
> >>4097300.html Thanks,
> >> Zarar
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog
Re: [jira] Issue Comment Edited: (CXF-803) Configuring interceptors
using annotations
Posted by "Jeff.Yu" <je...@iona.com>.
Hi, Glen
What do you mean by changing constant from
COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR, because in
the initializeAnnotationObjects() method, it might be "InInterceptor,
OutInterceptor,InFaultInterceptor, AbstractFeature" etc, and I don't
think we need to specify it so detail within a quite generic method.
BTW, I changed the COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to
COULD_NOT_CREATE_ANNOTATION_OBJECT in last patch, since it might be
FEATURES not INTERCEPTOR.
Thanks
Jeff Yu
Glen Mazza (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/CXF-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515646 ]
>
> Glen Mazza edited comment on CXF-803 at 7/26/07 5:53 AM:
> ---------------------------------------------------------
>
> Looks good! But will the committer of this patch please fix the constant in initializeAnnotationObjects() from COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
>
> Glen
>
>
>
> was:
> Looks good! But please fix the constant in initializeAnnotationObjects() from COULD_NOT_CREATE_ANNOTATION_INTERCEPOTR to xxxx_INTERCEPTOR.
>
> Glen
>
>
>
>> Configuring interceptors using annotations
>> ------------------------------------------
>>
>> Key: CXF-803
>> URL: https://issues.apache.org/jira/browse/CXF-803
>> Project: CXF
>> Issue Type: New Feature
>> Components: Configuration
>> Affects Versions: 2.0
>> Environment: All
>> Reporter: Zarar Siddiqi
>> Attachments: cxf-803-2.patch, cxf-803.patch
>>
>>
>> It would be helpful to configure interceptors using annotations. CXF would benefit by having annotations similar to XFire's org.codehaus.xfire.annotations.InHandlers and org.codehaus.xfire.annotations.OutHandlers as it would allow specifying specific interceptors for service implementations.
>> This issue came up on the mailing list: http://www.nabble.com/Configuring-interceptors-using-annotations-tf4097300.html
>> Thanks,
>> Zarar
>>
>
>