You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2022/02/21 02:01:08 UTC

[incubator-kyuubi] branch master updated: [KYUUBI #1876][FOLLOWUP] Update iceberg.name

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 1774c3f  [KYUUBI #1876][FOLLOWUP] Update iceberg.name
1774c3f is described below

commit 1774c3f17a6930c3db853cd7529b96dca0c2e00b
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Mon Feb 21 10:00:56 2022 +0800

    [KYUUBI #1876][FOLLOWUP] Update iceberg.name
    
    ### _Why are the changes needed?_
    
    We should also update `iceberg.name` when change the minor version of Spark
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #1942 from pan3793/spark-3.2.
    
    Closes #1876
    
    f178ceb8 [Cheng Pan] fix
    b0e79908 [Cheng Pan] nit
    a3f7e6f2 [Cheng Pan] [KYUUBI #1876] [FOLLOWUP] Update iceberg.name
    
    Authored-by: Cheng Pan <ch...@apache.org>
    Signed-off-by: Cheng Pan <ch...@apache.org>
---
 pom.xml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 4e7b2e8..adae5e3 100644
--- a/pom.xml
+++ b/pom.xml
@@ -113,7 +113,7 @@
         <hadoop.binary.version>3.2</hadoop.binary.version>
         <hive.version>2.3.9</hive.version>
         <hudi.version>0.10.0</hudi.version>
-        <iceberg.name>iceberg-spark3-runtime</iceberg.name>
+        <iceberg.name>iceberg-spark-runtime-3.2_${scala.binary.version}</iceberg.name>
         <iceberg.version>0.13.1</iceberg.version>
         <jackson.version>2.13.1</jackson.version>
         <jakarta.servlet-api.version>4.0.4</jakarta.servlet-api.version>
@@ -133,7 +133,10 @@
         <scopt.version>4.0.1</scopt.version>
         <slf4j.version>1.7.35</slf4j.version>
         <log4j.version>2.17.1</log4j.version>
-        <!-- If you change the minor version of Spark, don't forget to change the default 'delta.version' -->
+        <!--
+          DO NOT forget to change the following properties when change the minor version of Spark:
+          `delta.version`, `iceberg.name`
+          -->
         <spark.version>3.2.1</spark.version>
         <spark.archive.name>spark-${spark.version}-bin-hadoop${hadoop.binary.version}.tgz</spark.archive.name>
         <spark.archive.mirror>https://archive.apache.org/dist/spark/spark-${spark.version}</spark.archive.mirror>
@@ -1844,6 +1847,7 @@
             <properties>
                 <spark.version>3.0.3</spark.version>
                 <delta.version>0.8.0</delta.version>
+                <iceberg.name>iceberg-spark3-runtime</iceberg.name>
                 <!-- Hudi 0.10.0 still support Spark 3.0, but need build by user with specific profile -->
                 <maven.plugin.scalatest.exclude.tags>org.apache.kyuubi.tags.ExtendedSQLTest,org.apache.kyuubi.tags.HudiTest</maven.plugin.scalatest.exclude.tags>
             </properties>