You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/27 21:35:53 UTC

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1685: Incorporate dyn scalar kernels

alamb commented on a change in pull request #1685:
URL: https://github.com/apache/arrow-datafusion/pull/1685#discussion_r794017933



##########
File path: datafusion/src/physical_plan/expressions/binary.rs
##########
@@ -429,6 +444,24 @@ macro_rules! compute_utf8_op_scalar {
     }};
 }
 
+/// Invoke a compute kernel on a data array and a scalar value
+macro_rules! compute_utf8_op_dyn_scalar {
+    ($LEFT:expr, $RIGHT:expr, $OP:ident) => {{
+        if let ScalarValue::Utf8(Some(string_value)) = $RIGHT {

Review comment:
       👍  nice




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org