You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/10 02:27:08 UTC
[GitHub] [pulsar] gaozhangmin opened a new pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
gaozhangmin opened a new pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197
### Motivation
`zookeeperServers` and `configurationStoreServers` are deprecated.
### Modifications
`setZookeeperServers` and `setConfigurationStoreServers ` change to `setMetadataStoreUrl ` and `setConfigurationStoreServers `.
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1049849232
@mattisonchao @RobertIndie @nicoloboschi Please help review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin edited a comment on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin edited a comment on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1039772715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14197: [Test] Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a change in pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#discussion_r803390695
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneBuilder.java
##########
@@ -113,9 +113,9 @@ public PulsarStandalone build() {
// Use advertised address from config file
}
- // Set ZK server's host to localhost
- pulsarStandalone.getConfig().setZookeeperServers(zkServers + ":" + pulsarStandalone.getZkPort());
- pulsarStandalone.getConfig().setConfigurationStoreServers(zkServers + ":" + pulsarStandalone.getZkPort());
+ // Set metadata server's host to localhost
+ pulsarStandalone.getConfig().setMetadataStoreUrl(zkServers + ":" + pulsarStandalone.getZkPort());
Review comment:
I think it's better to use the syntax with the zk: prefix
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java
##########
@@ -90,8 +90,8 @@ public PulsarStandaloneStarter(String[] args) throws Exception {
this.setZkPort(Integer.parseInt(config.getMetadataStoreUrl().split(":")[1]));
}
}
- config.setZookeeperServers(zkServers + ":" + this.getZkPort());
- config.setConfigurationStoreServers(zkServers + ":" + this.getZkPort());
+ config.setMetadataStoreUrl(zkServers + ":" + this.getZkPort());
Review comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1041526402
@nicoloboschi PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1039970325
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin removed a comment on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1039990944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin edited a comment on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin edited a comment on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1039772715
@nicoloboschi I reverted changed on pulsarStandalone and function worker, since it has unknown bug made CI failed. I will open a new pr to solve it. PTAL。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a change in pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#discussion_r803514112
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneBuilder.java
##########
@@ -113,9 +113,10 @@ public PulsarStandalone build() {
// Use advertised address from config file
}
- // Set ZK server's host to localhost
- pulsarStandalone.getConfig().setZookeeperServers(zkServers + ":" + pulsarStandalone.getZkPort());
- pulsarStandalone.getConfig().setConfigurationStoreServers(zkServers + ":" + pulsarStandalone.getZkPort());
+ // Set metadata server's host to localhost
+ pulsarStandalone.getConfig().setMetadataStoreUrl("zk:" + zkServers + ":" + pulsarStandalone.getZkPort());
Review comment:
Could you the constant value in ZKMetadataStore? In this way is easier to find its usages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1039772715
@nicoloboschi I reverted changed on pulsarStandalone, since it has unknown bug made ci failed. I will open a new pr to solve it. PTAL。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1046958085
@lhotari PTAL at this, I think it's able to merge now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a change in pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#discussion_r803805228
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneBuilder.java
##########
@@ -109,13 +109,12 @@ public PulsarStandalone build() {
} else if (isBlank(pulsarStandalone.getConfig().getAdvertisedAddress())) {
// Use advertised address as local hostname
pulsarStandalone.getConfig().setAdvertisedAddress(ServiceConfigurationUtils.unsafeLocalhostResolve());
- } else {
- // Use advertised address from config file
}
- // Set ZK server's host to localhost
- pulsarStandalone.getConfig().setZookeeperServers(zkServers + ":" + pulsarStandalone.getZkPort());
- pulsarStandalone.getConfig().setConfigurationStoreServers(zkServers + ":" + pulsarStandalone.getZkPort());
+ String metadataStoreUrl = "zk:" + zkServers + ":" + pulsarStandalone.getZkPort();
Review comment:
why don't you use ZKMetadataStore#ZK_SCHEME_IDENTIFIER ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a change in pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on a change in pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#discussion_r803256283
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneBuilder.java
##########
@@ -114,8 +114,8 @@ public PulsarStandalone build() {
}
// Set ZK server's host to localhost
Review comment:
```suggestion
// Set metadata server's host to localhost
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1039990944
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1035020397
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1039772715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin edited a comment on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin edited a comment on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1039772715
@nicoloboschi I reverted changed on pulsarStandalone, since it has unknown bug made CI failed. I will open a new pr to solve it. PTAL。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin removed a comment on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1039990944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on a change in pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on a change in pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#discussion_r803522354
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneBuilder.java
##########
@@ -113,9 +113,10 @@ public PulsarStandalone build() {
// Use advertised address from config file
}
- // Set ZK server's host to localhost
- pulsarStandalone.getConfig().setZookeeperServers(zkServers + ":" + pulsarStandalone.getZkPort());
- pulsarStandalone.getConfig().setConfigurationStoreServers(zkServers + ":" + pulsarStandalone.getZkPort());
+ // Set metadata server's host to localhost
+ pulsarStandalone.getConfig().setMetadataStoreUrl("zk:" + zkServers + ":" + pulsarStandalone.getZkPort());
Review comment:
@nicoloboschi PTAL agin, Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1040000555
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1047659562
ping @lhotari
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin removed a comment on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1040061393
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: [Test] Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1050462422
> @gaozhangmin since the PR involves only test classes would you mind to prefix the pr title with [test] ?
Done. Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin removed a comment on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1039882358
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin removed a comment on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1046958085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1034427228
@gaozhangmin:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1039882358
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1040061393
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1036091089
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1035977351
The failed check is caused by incorrect ZK connection string in functionWork, After set ZK prefix in metadataStoreUrl,
I will open another pr to fix this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1048447159
ping @codelipenghui also PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1034426842
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1034727575
@nicoloboschi PTAL again, Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on a change in pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on a change in pull request #14197:
URL: https://github.com/apache/pulsar/pull/14197#discussion_r804320911
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneBuilder.java
##########
@@ -109,13 +109,12 @@ public PulsarStandalone build() {
} else if (isBlank(pulsarStandalone.getConfig().getAdvertisedAddress())) {
// Use advertised address as local hostname
pulsarStandalone.getConfig().setAdvertisedAddress(ServiceConfigurationUtils.unsafeLocalhostResolve());
- } else {
- // Use advertised address from config file
}
- // Set ZK server's host to localhost
- pulsarStandalone.getConfig().setZookeeperServers(zkServers + ":" + pulsarStandalone.getZkPort());
- pulsarStandalone.getConfig().setConfigurationStoreServers(zkServers + ":" + pulsarStandalone.getZkPort());
+ String metadataStoreUrl = "zk:" + zkServers + ":" + pulsarStandalone.getZkPort();
Review comment:
Resolved. Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org