You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/07/07 13:31:25 UTC
[GitHub] flink pull request #2212: [FLINK-4171] [metrics] Replace : chars in StatsD m...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2212
[FLINK-4171] [metrics] Replace : chars in StatsD metric names
The StatsD server rejects metrics whose names contain the : character. Therefore,
metric names which contain : chars will be altered so that : is replaced by -.
R @zentol
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixStatsDReporting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2212.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2212
----
commit b9237aa57576cdc9916739148fdb9832ccbf71e6
Author: Till Rohrmann <tr...@apache.org>
Date: 2016-07-07T13:26:51Z
[FLINK-4171] [metrics] Replace : chars in StatsD metric names
The StatsD server rejects metrics whose names contain the : character. Therefore,
metric names which contain : chars will be altered so that : is replaced by -.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2212: [FLINK-4171] [metrics] Replace : chars in StatsD m...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2212#discussion_r69907730
--- Diff: flink-core/src/main/java/org/apache/flink/metrics/reporter/AbstractReporter.java ---
@@ -74,4 +74,14 @@ public void notifyOfRemovedMetric(Metric metric, String metricName, AbstractMetr
}
}
}
+
+ /**
+ * Can be overridden by sub-classes to replace invalid characters in metric name.
+ *
+ * @param metricName Name of the metric
--- End diff --
Name should be lower case
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2212: [FLINK-4171] [metrics] Replace : chars in StatsD m...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2212
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2212: [FLINK-4171] [metrics] Replace : chars in StatsD metric n...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2212
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2212: [FLINK-4171] [metrics] Replace : chars in StatsD metric n...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2212
Thanks for reviewing @zentol. Will be merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2212: [FLINK-4171] [metrics] Replace : chars in StatsD m...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2212#discussion_r69907899
--- Diff: flink-core/src/main/java/org/apache/flink/metrics/reporter/AbstractReporter.java ---
@@ -74,4 +74,14 @@ public void notifyOfRemovedMetric(Metric metric, String metricName, AbstractMetr
}
}
}
+
+ /**
+ * Can be overridden by sub-classes to replace invalid characters in metric name.
+ *
+ * @param metricName Name of the metric
--- End diff --
or maybe not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---