You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by dpesch <gi...@git.apache.org> on 2014/05/14 18:38:24 UTC

[GitHub] cordova-plugin-file pull request: Fixed toURL() vs. toInternalURL(...

GitHub user dpesch opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/46

    Fixed toURL() vs. toInternalURL() information in the doku

    We use(d) toURL() to get 'cdvfile:' URLs which are independent from the application UUID (on iOS). I'll hope the change will now be more clear

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/11com7/cordova-plugin-file fix/doku-internalURL

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
    
----
commit 2599d697c246443840d6866d54f22dca2fc2b9d8
Author: Dominik Pesch <d....@11com7.de>
Date:   2014-05-14T16:02:07Z

    Fixed toURL() toInternalURL() information in the doku

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: Fixed toURL() vs. toInternalURL(...

Posted by dpesch <gi...@git.apache.org>.

Github user dpesch commented on the pull request:

    https://github.com/apache/cordova-plugin-file/pull/46#issuecomment-44058098
  
    Hi Ian, 
    thanks, I'll close it tomorrow. 
    
    dom
    
    > Am 23.05.2014 um 21:49 schrieb Ian Clelland <no...@github.com>:
    > 
    > I committed this (with a couple of small tweaks) -- you can close this now :)
    > 
    > —
    > Reply to this email directly or view it on GitHub.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: Fixed toURL() vs. toInternalURL(...

Posted by clelland <gi...@git.apache.org>.

Github user clelland commented on the pull request:

    https://github.com/apache/cordova-plugin-file/pull/46#issuecomment-44052989
  
    I committed this (with a couple of small tweaks) -- you can close this now :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-file pull request: Fixed toURL() vs. toInternalURL(...

Posted by dpesch <gi...@git.apache.org>.

Github user dpesch closed the pull request at:

    https://github.com/apache/cordova-plugin-file/pull/46


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---