You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Marcin (Jira)" <ji...@apache.org> on 2023/07/05 12:53:00 UTC
[jira] [Commented] (AMQ-8351) MaxFrameSize is not protecting against allocating big buffer
[ https://issues.apache.org/jira/browse/AMQ-8351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740190#comment-17740190 ]
Marcin commented on AMQ-8351:
-----------------------------
I don't agree with that.
BaseDataStreamMarshaller is allocating buffer based on different value than one that is compared with property wireFormat.maxFrameSize and this can lead to huge buffer allocation.
> MaxFrameSize is not protecting against allocating big buffer
> ------------------------------------------------------------
>
> Key: AMQ-8351
> URL: https://issues.apache.org/jira/browse/AMQ-8351
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
> Affects Versions: 5.12.2, 5.13.5, 5.14.5, 5.15.14, 5.16.2, 5.17.5
> Reporter: Marcin
> Priority: Major
>
> I found that some incoming data can allocate much bigger buffer (up to max int size) than frame size limit. This can lead to oom. I created junit test to show the problem:
>
> import java.io.ByteArrayInputStream;
> import java.io.ByteArrayOutputStream;
> import java.io.DataInput;
> import java.io.DataInputStream;
> import java.io.IOException;
> import com.google.common.primitives.Ints;
> import org.junit.jupiter.api.Test;
> import static org.junit.jupiter.api.Assertions.assertEquals;
> import static org.junit.jupiter.api.Assertions.assertThrows;
> class OpenWireFormatTest {
> @Test
> void maxFrameSizeTest() {
> ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
> try {
> outputStream.write(Ints.toByteArray(999));
> outputStream.write(1);
> outputStream.write(Ints.toByteArray(2000000000));
> outputStream.write(Ints.toByteArray(2000000000));
> outputStream.write(Ints.toByteArray(2000000000));
> outputStream.write(1);
> outputStream.write(Ints.toByteArray(2000000000));
> outputStream.write(Ints.toByteArray(2000000000));
> outputStream.write(Ints.toByteArray(2000000000));
> outputStream.write(Ints.toByteArray(2000000000));
> outputStream.write(Ints.toByteArray(2000000000));
> } catch (IOException e) {
> e.printStackTrace();
> }
> ByteArrayInputStream byteArrayInputStream = new ByteArrayInputStream(outputStream.toByteArray());
> DataInput dataInput = new DataInputStream(byteArrayInputStream);
> OpenWireFormat openWireFormat = new OpenWireFormat();
> openWireFormat.setMaxFrameSize(1000);
> final IOException ioException = assertThrows(IOException.class, () -> openWireFormat.unmarshal(dataInput));
> assertEquals("Frame size of 1907 MB larger than max allowed 100 MB", ioException.getMessage());
> }
--
This message was sent by Atlassian Jira
(v8.20.10#820010)