[jira] Commented: (NUTCH-859) Diff trunk and NutchBase

["Pham Tuan Minh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894037#action_12894037 ] 

Pham Tuan Minh commented on NUTCH-859:
--------------------------------------

Hi Julien,

I've just look at the new source code of nutchbase:

1. Build.xml file
org/apache/nutch/scoring/webgraph/**/*.java,org/apache/nutch/tools/compat/**/*.java is no longer existed

(target compile-core-test, compile-core)


2. solrindex-mapping.xml is not added
We shoud convert SolrIndexer.java to run solrindex command in local mode

3. /java/org/apache/nutch/crawl/FetchScheduleFactory.java

No need to use Class<?>, just Class is enough

4. nutch-default.xml

query-(basic|site|url)|summary-basic is not used

5. nutchbase use fetcher.threads.per.queue, why not use other feature like fetcher.threads.per.host, fetcher.threads.per.host.by.ip

6.Some java source contain $Id, some java source not, it is not unique style

// $Id: PrefixURLFilter.java 823614 2009-10-09 17:02:32Z ab $
// $Id$

We should define a standard format rules for source code, then using eclipse to format the whole source code in the same style
 
Thanks,



> Diff trunk and NutchBase 
> -------------------------
>
>                 Key: NUTCH-859
>                 URL: https://issues.apache.org/jira/browse/NUTCH-859
>             Project: Nutch
>          Issue Type: Task
>    Affects Versions: nutchbase
>            Reporter: Julien Nioche
>            Priority: Blocker
>             Fix For: nutchbase
>
>
> Before we turn NutchBase into trunk we need to make sure that all (more or less) recent changes in the trunk have been ported to NutchBase. I have done that recently but given that there is a very large number of changes I might have missed a few things here and there.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.