[GitHub] [geode] agingade commented on a change in pull request #6232: GEODE-8926: Calculate filter information after tx is applied to cache.

[GitBox <gi...@apache.org>]

agingade commented on a change in pull request #6232:
URL: https://github.com/apache/geode/pull/6232#discussion_r605245615



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java
##########
@@ -860,7 +871,11 @@ protected void applyChanges(List/* <TXEntryStateWithRegionAndKey> */ entries) {
         this.internalDuringApplyChanges.run();
       }
       try {
+        int size = pendingCallbacks.size();

Review comment:
       This could be moved outside for:
   
   int size = pendingCallbacks.size();
       for (Object entry : entries) {
         TXEntryStateWithRegionAndKey o = (TXEntryStateWithRegionAndKey) entry;
         if (this.internalDuringApplyChanges != null) {
           this.internalDuringApplyChanges.run();
         }
         try {
           //int size = pendingCallbacks.size();
           o.es.applyChanges(o.r, o.key, this);
           if (pendingCallbacks.size() > size) {
             size = pendingCallbacks.size();
             o.es.setPendingCallback(pendingCallbacks.get(size));
           }
         } catch (RegionDestroyedException ex) {




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org