You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/16 21:26:00 UTC

[jira] [Commented] (AIRFLOW-3718) Make official Airflow Image multi-layered

    [ https://issues.apache.org/jira/browse/AIRFLOW-3718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744469#comment-16744469 ] 

ASF GitHub Bot commented on AIRFLOW-3718:
-----------------------------------------

potiuk commented on pull request #4543: [AIRFLOW-3718] Multi-layered version of the docker image
URL: https://github.com/apache/airflow/pull/4543
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3718
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Current official Airflow image is rebuilt from the scratch every time new commit is done to the repo. It is a "mono-layered" one and does not use Docker's multi-layer architecture.
   
   This means that builds take longer and that users downloading the image regularly will always download full image. With multi-layered approach and caching enabled in Docker Hub we can optimise it to download only the layers that changed.
   
   ### Tests
   
   - [x] No tests for the image so far.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] No docs
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make official Airflow Image multi-layered
> -----------------------------------------
>
>                 Key: AIRFLOW-3718
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3718
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> Current official Airflow image is rebuilt from the scratch every time new commit is done to the repo. It is a "mono-layered" one and does not use Docker's multi-layer architecture.
> This means that builds take longer and that users downloading the image regularly will always download full image. With multi-layered approach and caching enabled in Docker Hub we can optimise it to download only the layers that changed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)