[GitHub] jackjlli commented on issue #3864: Add controller mode logic in ControllerStarter

[GitBox <gi...@apache.org>]

jackjlli commented on issue #3864: Add controller mode logic in ControllerStarter
URL: https://github.com/apache/incubator-pinot/pull/3864#issuecomment-467620193
 
 
   @mcvsubbu Here's the answers:
   1. Participant controller would be needed to add state model but for now since there's no `controllerResource` logic in this PR, participant role would only be shown in the cluster and won't have other effect yet. The only difference is that some tests checking the number of instances might need to update the expected number.
   2. Pinot only controller would be registered as both admin and participant role. Instead of participant role, admin role will do the stuffs as the controller in dual mode does. But since we haven't change the leadership logic in this PR yet, pinot-only controller is kind of useless by now, since it can't handle periodic tasks and realtime segment completion. I've added some code in controllerStarter to avoid using pinot-only controller in production. Once the whole logic has fully been merged, this role can be unlocked for production.
   3. I've tested this PR manually by setting up a cluster locally. Things are working fine, like adding table, uploading segments, etc.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org