[PR] RANGER-4920: kms docker - Fix kms service url, volume support for configs [ranger]

["fateh288 (via GitHub)" <gi...@apache.org>]

fateh288 opened a new pull request, #395:
URL: https://github.com/apache/ranger/pull/395

   
   
   ## What changes were proposed in this pull request?
   
   1) Fixed service url for kms as key create operation was not succeeding
   2) Introduced volume support for kms docker images so that image re-create is not required for change in configs 
   
   ## How was this patch tested?
   
   1) Created kms docker image
   2) Made some changes to kms-logback.xml
   3) Restart kms docker container
   4) updated kms-logback.xml correctly used now for logging (image re-create not required)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] RANGER-4920: kms docker - Fix kms service url, volume support for configs [ranger]

["mneethiraj (via GitHub)" <gi...@apache.org>]

mneethiraj commented on code in PR #395:
URL: https://github.com/apache/ranger/pull/395#discussion_r1779308443


##########
plugin-kms/scripts/enable-kms-plugin.sh:
##########
@@ -377,6 +377,13 @@ then
         	fi
 			archivefn="${HCOMPONENT_CONF_DIR}/.${orgfn}.${dt}"
         	newfn="${HCOMPONENT_CONF_DIR}/.${orgfn}-new.${dt}"
+          if [ "${KMS_IN_DOCKER}" ]; then
+            TEMP_DIR="${HCOMPONENT_
+            CONF_DIR}"/saved

Review Comment:
   Lines 381 and 382 should be combined?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org