You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/15 19:13:17 UTC
[GitHub] [airflow] turbaszek commented on a change in pull request #21430: Normalize *_conn_id parameters in BigQuery sensors
turbaszek commented on a change in pull request #21430:
URL: https://github.com/apache/airflow/pull/21430#discussion_r807210705
##########
File path: airflow/providers/google/cloud/sensors/bigquery.py
##########
@@ -64,25 +71,31 @@ def __init__(
project_id: str,
dataset_id: str,
table_id: str,
- bigquery_conn_id: str = 'google_cloud_default',
+ gcp_conn_id: str = 'google_cloud_default',
Review comment:
Just an idea for further improvement - maybe it would be good to introduce constant for this value and use it in all cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org