You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/18 05:46:20 UTC

[GitHub] [incubator-devlake] abeizn opened a new pull request, #4231: fix: update apk to apt-get on tini

abeizn opened a new pull request, #4231:
URL: https://github.com/apache/incubator-devlake/pull/4231

   ### Summary
   due to alpine -->  debian, so we need to update `apk` to `apt-get` on tini, add docker init, solve zombie process.
   
   ### Does this close any open issues?
   Closes #3919 
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] mindlesscloud merged pull request #4231: fix: update apk to apt-get on tini

Posted by GitBox <gi...@apache.org>.
mindlesscloud merged PR #4231:
URL: https://github.com/apache/incubator-devlake/pull/4231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #4231: fix: update apk to apt-get on tini

Posted by GitBox <gi...@apache.org>.
keon94 commented on code in PR #4231:
URL: https://github.com/apache/incubator-devlake/pull/4231#discussion_r1073859890


##########
backend/Dockerfile:
##########
@@ -157,7 +157,7 @@ COPY --from=build /app/resources/tap /app/resources/tap
 ENV PATH="/app/bin:${PATH}"
 
 # add tini, prevent zombie process
-RUN apk add --no-cache tini
+RUN apt-get install -y tini

Review Comment:
   This needs a "apt-get update" before this line, otherwise the package manager can't find tini



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org