You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/30 09:30:28 UTC
[GitHub] [incubator-doris] WingsGo opened a new pull request #3986: [Config]Allower use to config different thrift server model
WingsGo opened a new pull request #3986:
URL: https://github.com/apache/incubator-doris/pull/3986
Doris only support TThreadPoolServer model in thrift server, but the
server model is not effective in some high concurrency scenario, so this
PR introduced new config to allower use to choose different server model
by their scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on pull request #3986: [Config]Allower use to config different thrift server model
Posted by GitBox <gi...@apache.org>.
WingsGo commented on pull request #3986:
URL: https://github.com/apache/incubator-doris/pull/3986#issuecomment-651682615
For #3987
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo edited a comment on pull request #3986: [Config]Allower use to config different thrift server model
Posted by GitBox <gi...@apache.org>.
WingsGo edited a comment on pull request #3986:
URL: https://github.com/apache/incubator-doris/pull/3986#issuecomment-651743033
> Better to use a `string` instead of `int` type of this config.
> And TSimpleServer seems unnecessary.
use string is better and easy to understand, but Config have no check logic, we can only set default server model when use have typo error like `Threadd`,In this case, user may think they use a `Threaded` server model, but it is not what he think, use int type is to avoid situation like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3986: [Config]Allower use to config different thrift server model
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3986:
URL: https://github.com/apache/incubator-doris/pull/3986
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on pull request #3986: [Config]Allower use to config different thrift server model
Posted by GitBox <gi...@apache.org>.
WingsGo commented on pull request #3986:
URL: https://github.com/apache/incubator-doris/pull/3986#issuecomment-651743033
> Better to use a `string` instead of `int` type of this config.
> And TSimpleServer seems unnecessary.
use string is better, but Config have no check logic, we can only set default server model when use have typo error like `Threadd`,In this case, user may think they use a `Threaded` server model, but it is not what he think, use int type is to avoid situation like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on pull request #3986: [Config]Allower use to config different thrift server model
Posted by GitBox <gi...@apache.org>.
WingsGo commented on pull request #3986:
URL: https://github.com/apache/incubator-doris/pull/3986#issuecomment-652140409
> > > Better to use a `string` instead of `int` type of this config.
> > > And TSimpleServer seems unnecessary.
> >
> >
> > use string is better and easy to understand, but Config have no check logic, we can only set default server model when use have typo error like `Threadd`,In this case, user may think they use a `Threaded` server model, but it is not what he think, use int type is to avoid situation like this.
>
> Actually, the config SHOULD has a validation logic. We may add it later.
> So I suggest to keep the config in a friendly way, and we can add the checking later.
It look like the best solution, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org