You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@otava.apache.org by "Gerrrr (via GitHub)" <gi...@apache.org> on 2026/04/20 04:30:50 UTC
[PR] Build multi-platform Docker images (amd64 + arm64) [otava]
Gerrrr opened a new pull request, #149:
URL: https://github.com/apache/otava/pull/149
The docker buildx build command had no `--platform` flag, so images were built only for the host architecture. This caused examples to fail on amd64 when the published image was arm64-only.
- Add `--platform linux/amd64,linux/arm64` to buildx commands in `tox.ini`
- Add QEMU and Buildx setup steps to CI workflow
- Simplify tox docker-push to push directly to Dockerhub
- Update RELEASE.md to use `tox -e docker-push`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build multi-platform Docker images (amd64 + arm64) [otava]
Posted by "henrikingo (via GitHub)" <gi...@apache.org>.
henrikingo commented on PR #149:
URL: https://github.com/apache/otava/pull/149#issuecomment-4296115706
I'm +1 on this if nobody else has any comments. Leaving to Alex to merge though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build multi-platform Docker images (amd64 + arm64) [otava]
Posted by "Gerrrr (via GitHub)" <gi...@apache.org>.
Gerrrr merged PR #149:
URL: https://github.com/apache/otava/pull/149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build multi-platform Docker images (amd64 + arm64) [otava]
Posted by "Gerrrr (via GitHub)" <gi...@apache.org>.
Gerrrr commented on PR #149:
URL: https://github.com/apache/otava/pull/149#issuecomment-4293005202
> Did you run this somewhere? I assume yes, but if so, where should I expect to see docker images coming through on the other side
> Why?
These are connected stories :)
First, I added buildx to tox and CI to build the image for both architectures. The CI succeeded, but took 4 times longer (36 minutes instead of 9). While waiting for that CI job to finish, I decided to run it locally to find the potential issues sooner. On my personal laptop, `uv run tox -e docker-build` failed with out of memory error while building numpy. It turned out that building numpy via QEMU takes forever AND consumes a ton of memory as it builds a bunch of C/C++ libraries.
Why did the docker-build build numpy instead of just using the wheels? Numpy provides wheels for Python 3.14 only starting with version `2.3.2`... but that version only supports Python >=3.11.
The combination of these issues lead me to upgrading numpy for Python 3.14 which in turn enabled fast cross-arch builds. As a result of these changes, GH CI runs in 4.5 minutes instead of 9/36 (baseline/multiarch) and does not crash with cryptic errors on Macbook Air 2022.
> where should I expect to see docker images coming through on the other side.
We do not have yet a release CI job automating publishing to Dockerhub and PyPI. For the release process, you'll need to 1) check out the accepted version's tag and 2) build locally, then push to Dockerhub. I updated the release instructions in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build multi-platform Docker images (amd64 + arm64) [otava]
Posted by "henrikingo (via GitHub)" <gi...@apache.org>.
henrikingo commented on code in PR #149:
URL: https://github.com/apache/otava/pull/149#discussion_r3120721132
##########
.github/workflows/python-app.yml:
##########
@@ -61,6 +61,12 @@ jobs:
steps:
- uses: actions/checkout@v4
+ - name: Set up QEMU
Review Comment:
Probably better in its own commit, but why is the workflow called python-app :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build multi-platform Docker images (amd64 + arm64) [otava]
Posted by "henrikingo (via GitHub)" <gi...@apache.org>.
henrikingo commented on PR #149:
URL: https://github.com/apache/otava/pull/149#issuecomment-4296108393
Ok thanks for the explanation.
> For the release process, you'll need to 1) check out the accepted version's tag and 2) build locally, then push to Dockerhub.
I'll see what I can do about automating this. I don't think that we should publish release that someone built on their laptop. But I'd rather proceed with the release and designate the docker parts experimental. IMO the python parts deserve a releast now and shouldn''t be blocked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org