You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/11 10:21:23 UTC

[GitHub] [flink] Airblader commented on pull request #17449: [FLINK-24504][table-planner] Flink common expression elimination

Airblader commented on pull request #17449:
URL: https://github.com/apache/flink/pull/17449#issuecomment-939893772


   A simple map with the code as key doesn't seem sufficient to me. What if the function is non-deterministic? What if it is called with arguments which are calls to non-deterministic functions? 
   
   I think in general this should be handled in the optimizer, not the code generation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org