You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@stanbol.apache.org by "KuiLIU (JIRA)" <ji...@apache.org> on 2018/04/17 14:18:00 UTC

[jira] [Updated] (STANBOL-1468) Inconsistent method name "toLRU"

     [ https://issues.apache.org/jira/browse/STANBOL-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

KuiLIU updated STANBOL-1468:
----------------------------
     Attachment: rename-method.patch
    Description: 
The following method "toLRU" is adding the data of the paraement 'r' to the variable "lru", but it is named "toLRU". "toLRU" seems to mean that converting one object to another one, so that "toLRU" may be confusing. "addToLRU" should be better.

{code:java}
     private void toLRU(Representation r){
         lru.put(r.getId(), r);
     }
{code}


> Inconsistent method name "toLRU"
> --------------------------------
>
>                 Key: STANBOL-1468
>                 URL: https://issues.apache.org/jira/browse/STANBOL-1468
>             Project: Stanbol
>          Issue Type: Improvement
>            Reporter: KuiLIU
>            Priority: Major
>         Attachments: rename-method.patch
>
>
> The following method "toLRU" is adding the data of the paraement 'r' to the variable "lru", but it is named "toLRU". "toLRU" seems to mean that converting one object to another one, so that "toLRU" may be confusing. "addToLRU" should be better.
> {code:java}
>      private void toLRU(Representation r){
>          lru.put(r.getId(), r);
>      }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)