You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bo...@apache.org on 2021/09/26 08:58:13 UTC
[ant] branch master updated: Performance:
This is an automated email from the ASF dual-hosted git repository.
bodewig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ant.git
The following commit(s) were added to refs/heads/master by this push:
new 8b4d346 Performance:
new 87ac5d5 Merge pull request #157 from arturobernalg/feature/performance
8b4d346 is described below
commit 8b4d346c75815609b8f67c238d49b21ba1d295d3
Author: Arturo Bernal <ar...@gmail.com>
AuthorDate: Tue Aug 31 21:14:51 2021 +0200
Performance:
* Use arrayCopy
* Avoid redundant String.format
* Exit the loop early
---
CONTRIBUTORS | 1 +
contributors.xml | 4 ++++
src/main/org/apache/tools/ant/NoBannerLogger.java | 2 +-
src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java | 4 ++--
src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java | 4 ++--
src/main/org/apache/tools/bzip2/CBZip2OutputStream.java | 1 +
6 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/CONTRIBUTORS b/CONTRIBUTORS
index bc935a7..22299a8 100644
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -36,6 +36,7 @@ Arcadius Ahouansou
Arjan Veenstra
Arnaud Vandyck
Arnout J. Kuiper
+Arturo Bernal
Arun Jamwal
Aslak Hellesôy
Atsuhiko Yamanaka
diff --git a/contributors.xml b/contributors.xml
index c84ec14..bbdbc1f 100644
--- a/contributors.xml
+++ b/contributors.xml
@@ -173,6 +173,10 @@
<last>Kuiper</last>
</name>
<name>
+ <first>Arturo</first>
+ <last>Bernal</last>
+ </name>
+ <name>
<first>Arun</first>
<last>Jamwal</last>
</name>
diff --git a/src/main/org/apache/tools/ant/NoBannerLogger.java b/src/main/org/apache/tools/ant/NoBannerLogger.java
index b2e5c14..628390d 100644
--- a/src/main/org/apache/tools/ant/NoBannerLogger.java
+++ b/src/main/org/apache/tools/ant/NoBannerLogger.java
@@ -88,7 +88,7 @@ public class NoBannerLogger extends DefaultLogger {
synchronized (this) {
if (null != targetName) {
- out.println(String.format("%n%s:", targetName));
+ out.printf("%n%s:%n", targetName);
targetName = null;
}
}
diff --git a/src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java b/src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java
index 62237ef..6d8b211 100644
--- a/src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java
+++ b/src/main/org/apache/tools/ant/taskdefs/RecorderEntry.java
@@ -107,9 +107,9 @@ public class RecorderEntry implements BuildLogger, SubBuildListener {
Throwable error = event.getException();
if (error == null) {
- out.println(String.format("%nBUILD SUCCESSFUL"));
+ out.printf("%nBUILD SUCCESSFUL%n");
} else {
- out.println(String.format("%nBUILD FAILED%n"));
+ out.printf("%nBUILD FAILED%n%n");
error.printStackTrace(out); //NOSONAR
}
}
diff --git a/src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java b/src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java
index 637e9bd..8ce8059 100644
--- a/src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java
+++ b/src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java
@@ -94,8 +94,8 @@ public class JavacExternal extends DefaultCompilerAdapter {
for(int i = nonArgFileOptionIdx + 1; i < commandLine.length; i++) {
if (!isArgFileEligible(commandLine[i])) {
String option = commandLine[i];
- for(int j = i - 1; j >= nonArgFileOptionIdx; j--) {
- commandLine[j + 1] = commandLine[j];
+ if (i - nonArgFileOptionIdx >= 0) {
+ System.arraycopy( commandLine, nonArgFileOptionIdx, commandLine, nonArgFileOptionIdx + 1, i - nonArgFileOptionIdx );
}
commandLine[nonArgFileOptionIdx] = option;
nonArgFileOptionIdx++;
diff --git a/src/main/org/apache/tools/bzip2/CBZip2OutputStream.java b/src/main/org/apache/tools/bzip2/CBZip2OutputStream.java
index 7919a6a..37cfe32 100644
--- a/src/main/org/apache/tools/bzip2/CBZip2OutputStream.java
+++ b/src/main/org/apache/tools/bzip2/CBZip2OutputStream.java
@@ -1210,6 +1210,7 @@ public class CBZip2OutputStream extends OutputStream
for (int j = 16; --j >= 0;) {
if (inUse[i16 + j]) {
inUse16[i] = true;
+ break;
}
}
}