[GitHub] [beam] lukecwik commented on a change in pull request #12519: [WIP][BEAM-10670] Make Read execute as a splittable DoFn by default for the Java DirectRunner.

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #12519:
URL: https://github.com/apache/beam/pull/12519#discussion_r469410730



##########
File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SplittableParDo.java
##########
@@ -630,4 +635,38 @@ public void tearDown() {
       invoker = null;
     }
   }
+
+  /**
+   * Throws an {@link IllegalArgumentException} if the pipeline contains any primitive read
+   * transforms that have not been expanded to be executed as {@link DoFn splittable DoFns}.
+   */
+  public static void validateNoPrimitiveReads(Pipeline pipeline) {
+    pipeline.traverseTopologically(new ValidateNoPrimitiveReads());
+  }
+
+  /**
+   * A {@link org.apache.beam.sdk.Pipeline.PipelineVisitor} that ensures that the pipeline does not
+   * contain any primitive reads.

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org