[GitHub] [phoenix] virajjasani commented on a change in pull request #1175: PHOENIX-6421 Selecting an indexed array value from an uncovered column with local index returns NULL.

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #1175:
URL: https://github.com/apache/phoenix/pull/1175#discussion_r598871544



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java
##########
@@ -694,6 +695,11 @@ public Void visit(ProjectedColumnExpression expression) {
                          if (expression.getDataType().isArrayType()) {
                              indexProjectedColumns.add(expression);
                              PColumn col = expression.getColumn();
+                             // hack'ish... For covered columns with local indexes we defer to the server.

Review comment:
       Tested locally and looks good

##########
File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/RegionScannerFactory.java
##########
@@ -367,10 +367,6 @@ private boolean scanTillScanStartRow(final RegionScanner s,
           if (isDummy(result)) {
             return true;
           }
-          if (arrayFuncRefs != null && arrayFuncRefs.length > 0 && arrayKVRefs.size() > 0) {
-            int arrayElementCellPosition = replaceArrayIndexElement(arrayKVRefs, arrayFuncRefs, result);
-            arrayElementCell = result.get(arrayElementCellPosition);

Review comment:
       So true, much needed change 👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org