[pulsar-helm-chart] branch master updated: make proxy httpNumThreads configurable (#251)

[mm...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mmarshall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git


The following commit(s) were added to refs/heads/master by this push:
     new c05f659  make proxy httpNumThreads configurable (#251)
c05f659 is described below

commit c05f659ff40f2274ac75e3baacddc0afd3bb220e
Author: Filipe Caixeta <fi...@gmail.com>
AuthorDate: Sun Jun 26 01:57:30 2022 -0300

    make proxy httpNumThreads configurable (#251)
    
    Fixes https://github.com/apache/pulsar-helm-chart/issues/250
    
    ### Motivation
    
    `httpNumThreads` is hardcoded to 8 in `charts/pulsar/templates/proxy-configmap.yaml`
    When trying to override in `values.yaml` by using `proxy.configData.httpNumThreads` we get an error because the keys get duplicated.
    This happens because `{{ toYaml .Values.proxy.configData | indent 2 }}` doesn't deduplicate the keys and there is no other way to set `httpNumThreads`
    
    ### Modifications
    
    Removing the key from charts/pulsar/templates/proxy-configmap.yaml and adding it to the values yaml solves the problem.
    
    ### Verifying this change
    
    - [x] Make sure that the change passes the CI checks.
---
 charts/pulsar/templates/proxy-configmap.yaml | 1 -
 charts/pulsar/values.yaml                    | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/charts/pulsar/templates/proxy-configmap.yaml b/charts/pulsar/templates/proxy-configmap.yaml
index a069878..66ea48d 100644
--- a/charts/pulsar/templates/proxy-configmap.yaml
+++ b/charts/pulsar/templates/proxy-configmap.yaml
@@ -28,7 +28,6 @@ metadata:
     component: {{ .Values.proxy.component }}
 data:
   clusterName: {{ template "pulsar.cluster.name" . }}
-  httpNumThreads: "8"
   statusFilePath: "{{ template "pulsar.home" . }}/status"
   # prometheus needs to access /metrics endpoint
   webServicePort: "{{ .Values.proxy.ports.http }}"
diff --git a/charts/pulsar/values.yaml b/charts/pulsar/values.yaml
index f3da13e..a44b8e5 100644
--- a/charts/pulsar/values.yaml
+++ b/charts/pulsar/values.yaml
@@ -889,6 +889,7 @@ proxy:
       -XX:-ResizePLAB
       -XX:+ExitOnOutOfMemoryError
       -XX:+PerfDisableSharedMem
+    httpNumThreads: "8"
   ## Add a custom command to the start up process of the proxy pods (e.g. update-ca-certificates, jvm commands, etc)
   additionalCommand:
   ## Proxy service