You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/14 02:16:56 UTC
[GitHub] [airflow] uranusjr opened a new pull request #15361: Import Connection lazily in hooks to avoid cycles
uranusjr opened a new pull request #15361:
URL: https://github.com/apache/airflow/pull/15361
The current implementation imports Connection on import time, which causes a circular import when a model class needs to reference a hook class.
By applying this fix, the airflow.hooks package is separated with airflow.models on import time, so custom models can reference hooks. Custom hooks, on the other hand, generally don't reference model classes.
Fix #15325.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15361: Import Connection lazily in hooks to avoid cycles
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15361:
URL: https://github.com/apache/airflow/pull/15361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15361: Import Connection lazily in hooks to avoid cycles
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15361:
URL: https://github.com/apache/airflow/pull/15361#issuecomment-819249708
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org