You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Kevin Brown (JIRA)" <ji...@apache.org> on 2008/06/05 02:01:45 UTC
[jira] Created: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
-------------------------------------------------------------------
Key: SHINDIG-342
URL: https://issues.apache.org/jira/browse/SHINDIG-342
Project: Shindig
Issue Type: Sub-task
Reporter: Kevin Brown
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Eaton updated SHINDIG-342:
--------------------------------
Attachment: nooauthjson.patch
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Assignee: Brian Eaton
> Attachments: nooauthjson.patch, oauth08.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607746#action_12607746 ]
Kevin Brown commented on SHINDIG-342:
-------------------------------------
That's ok, but then it doesn't exercise the loading -- it would be even better if this took a reader or something instead of a resource path.
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Assignee: Brian Eaton
> Attachments: nooauthjson.patch, oauth08.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607703#action_12607703 ]
Brian Eaton commented on SHINDIG-342:
-------------------------------------
Which tests are failing for you? I didn't intend to hard code file path.
Some of those exceptions are getting propagated all the way out to javascript, and I care quite a bit that the message is readable. The tests are somewhat brittle, but I'm willing to pay the cost of maintaining them. Better to have Shindig developers maintain the test than have a gadget developer need to contact support just to figure out they've got a typo in their spec.
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Assignee: Brian Eaton
> Attachments: oauth08.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607719#action_12607719 ]
Kevin Brown commented on SHINDIG-342:
-------------------------------------
"Which tests are failing for you? I didn't intend to hard code file path. "
There's a reliance on config/oauth.json in the tests because the classes that read this file don't make it configurable. This makes the tests fail in many situations (eclipse with a single root project as an example). It also means that the tests break if I actually modify my own configuration, which makes no sense.
The tests should be using test data.
Propagating exception messages all the way out to the client is also something we should work on eliminating; that's impossible to localize and difficult to update over time.
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Assignee: Brian Eaton
> Attachments: oauth08.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Eaton updated SHINDIG-342:
--------------------------------
Attachment: (was: oauthspec.patch)
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Attachments: oauthspec.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Eaton reopened SHINDIG-342:
---------------------------------
No. Shindig still doesn't use any of this data. It gets parsed, and then ignored.
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Assignee: Brian Eaton
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Eaton updated SHINDIG-342:
--------------------------------
Attachment: (was: oauth08.patch)
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Assignee: Brian Eaton
> Attachments: oauth08.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605106#action_12605106 ]
Brian Eaton commented on SHINDIG-342:
-------------------------------------
r667888 adds the parsing. Shindig is still horribly ignorant of how to actually *use* the parsed data, of course, so I'll leave this open.
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Assignee: Brian Eaton
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Eaton updated SHINDIG-342:
--------------------------------
Attachment: oauthspec.patch
First swing at this, probably not ready for submission yet.
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Attachments: oauthspec.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Eaton updated SHINDIG-342:
--------------------------------
Attachment: oauth08.patch
Bug fixes, code cleanup since last revision.
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Assignee: Brian Eaton
> Attachments: oauth08.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown resolved SHINDIG-342.
---------------------------------
Resolution: Fixed
Committed by Brian.
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Assignee: Brian Eaton
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Eaton reassigned SHINDIG-342:
-----------------------------------
Assignee: Brian Eaton
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Assignee: Brian Eaton
> Attachments: oauthspec.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Eaton updated SHINDIG-342:
--------------------------------
Attachment: oauth08.patch
Javascript interface changes.
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Assignee: Brian Eaton
> Attachments: oauth08.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607728#action_12607728 ]
Brian Eaton commented on SHINDIG-342:
-------------------------------------
Does the attached nooauthjson.patch fix the test failures for you?
Re: exception messages. I more or less agree. We don't know quite enough about what kind of help gadget developers are going to need to do the right thing now, but eventually we should do much better than dumping a stack trace in their lap.
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Assignee: Brian Eaton
> Attachments: nooauthjson.patch, oauth08.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607699#action_12607699 ]
Kevin Brown commented on SHINDIG-342:
-------------------------------------
Looks good, although I'll reiterate that I don't think tests should be verifying the message on an exception -- they should be verifying the type of the exception, or possibly some enumeration value in a pinch.
Oh -- and can we fix the tests to not depend on a static file name? It makes it hard to run tests in many situations (like an IDE).
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Assignee: Brian Eaton
> Attachments: oauth08.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Eaton updated SHINDIG-342:
--------------------------------
Attachment: (was: oauthspec.patch)
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Assignee: Brian Eaton
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-342) Support /ModulePrefs/OAuth
(standardization of the "oauth" feature)
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Eaton updated SHINDIG-342:
--------------------------------
Attachment: oauthspec.patch
Minor updates from last patch.
> Support /ModulePrefs/OAuth (standardization of the "oauth" feature)
> -------------------------------------------------------------------
>
> Key: SHINDIG-342
> URL: https://issues.apache.org/jira/browse/SHINDIG-342
> Project: Shindig
> Issue Type: Sub-task
> Reporter: Kevin Brown
> Attachments: oauthspec.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.