[GitHub] [iceberg] rdblue commented on a change in pull request #1897: Add support for timestamp with local zone in Hive3

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1897:
URL: https://github.com/apache/iceberg/pull/1897#discussion_r541129980



##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveSchemaConverter.java
##########
@@ -99,6 +99,10 @@ Type convertType(TypeInfo typeInfo) {
           case INTERVAL_YEAR_MONTH:
           case INTERVAL_DAY_TIME:
           default:
+            // special case for Timestamp with Local TZ which is only available in Hive3
+            if ("TIMESTAMPLOCALTZ".equals(((PrimitiveTypeInfo) typeInfo).getPrimitiveCategory().name())) {

Review comment:
       `equalsIgnoreCase`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org