You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Mark Hanson <ha...@vmware.com> on 2020/08/12 23:40:17 UTC

[Proposal] Backport GEODE-8422 to support/1.13

Hi All,

We have found a case where tombstones were being cleared when the region was not initialized. This was causing some test failures and potential field failures. We would like to put this into support/1.13.

Thanks,
Mark

Re: [Proposal] Backport GEODE-8422 to support/1.13

Posted by Donal Evans <do...@vmware.com>.
+1
________________________________
From: Mark Hanson <ha...@vmware.com>
Sent: Wednesday, August 12, 2020 4:40 PM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: [Proposal] Backport GEODE-8422 to support/1.13

Hi All,

We have found a case where tombstones were being cleared when the region was not initialized. This was causing some test failures and potential field failures. We would like to put this into support/1.13.

Thanks,
Mark

Re: [Proposal] Backport GEODE-8422 to support/1.13

Posted by Dave Barnes <dv...@gmail.com>.
I was waiting until you confirmed that the fix had successfully completed a test cycle on develop. 
I see Owen gave it the green light in that regard, so all is in order.
Thanks for this — at the beginning of the week, it was our last known blocker.
-Dave

> On Aug 13, 2020, at 5:08 PM, Mark Hanson <ha...@vmware.com> wrote:
> 
> I just cherry-picked the change in. Thanks!
> 
> On 8/13/20, 4:55 PM, "Dick Cavender" <di...@vmware.com> wrote:
> 
>    +1
> 
>    -----Original Message-----
>    From: Mark Hanson <ha...@vmware.com> 
>    Sent: Thursday, August 13, 2020 4:46 PM
>    To: dev@geode.apache.org
>    Subject: Re: [Proposal] Backport GEODE-8422 to support/1.13
> 
>    Hi All, 
> 
>    I can't remember for sure, but I think we need 3 approvals?
> 
>    Thanks,
>    Mark
> 
>    On 8/13/20, 4:22 PM, "Owen Nichols" <on...@vmware.com> wrote:
> 
>        +1 from me.  Pipeline and all other testing I've seen suggests this fix is good
> 
>        On 8/12/20, 4:52 PM, "Jianxia Chen" <jc...@apache.org> wrote:
> 
>            +1
> 
>            On Wed, Aug 12, 2020 at 4:41 PM Mark Hanson <ha...@vmware.com> wrote:
> 
>> Hi All,
>> 
>> We have found a case where tombstones were being cleared when the region
>> was not initialized. This was causing some test failures and potential
>> field failures. We would like to put this into support/1.13.
>> 
>> Thanks,
>> Mark
>> 
> 
> 
> 


Re: [Proposal] Backport GEODE-8422 to support/1.13

Posted by Mark Hanson <ha...@vmware.com>.
I just cherry-picked the change in. Thanks!

On 8/13/20, 4:55 PM, "Dick Cavender" <di...@vmware.com> wrote:

    +1

    -----Original Message-----
    From: Mark Hanson <ha...@vmware.com> 
    Sent: Thursday, August 13, 2020 4:46 PM
    To: dev@geode.apache.org
    Subject: Re: [Proposal] Backport GEODE-8422 to support/1.13

    Hi All, 

    I can't remember for sure, but I think we need 3 approvals?

    Thanks,
    Mark

    On 8/13/20, 4:22 PM, "Owen Nichols" <on...@vmware.com> wrote:

        +1 from me.  Pipeline and all other testing I've seen suggests this fix is good

        On 8/12/20, 4:52 PM, "Jianxia Chen" <jc...@apache.org> wrote:

            +1

            On Wed, Aug 12, 2020 at 4:41 PM Mark Hanson <ha...@vmware.com> wrote:

            > Hi All,
            >
            > We have found a case where tombstones were being cleared when the region
            > was not initialized. This was causing some test failures and potential
            > field failures. We would like to put this into support/1.13.
            >
            > Thanks,
            > Mark
            >




RE: [Proposal] Backport GEODE-8422 to support/1.13

Posted by Dick Cavender <di...@vmware.com>.
+1

-----Original Message-----
From: Mark Hanson <ha...@vmware.com> 
Sent: Thursday, August 13, 2020 4:46 PM
To: dev@geode.apache.org
Subject: Re: [Proposal] Backport GEODE-8422 to support/1.13

Hi All, 

I can't remember for sure, but I think we need 3 approvals?

Thanks,
Mark

On 8/13/20, 4:22 PM, "Owen Nichols" <on...@vmware.com> wrote:

    +1 from me.  Pipeline and all other testing I've seen suggests this fix is good

    On 8/12/20, 4:52 PM, "Jianxia Chen" <jc...@apache.org> wrote:

        +1

        On Wed, Aug 12, 2020 at 4:41 PM Mark Hanson <ha...@vmware.com> wrote:

        > Hi All,
        >
        > We have found a case where tombstones were being cleared when the region
        > was not initialized. This was causing some test failures and potential
        > field failures. We would like to put this into support/1.13.
        >
        > Thanks,
        > Mark
        >



Re: [Proposal] Backport GEODE-8422 to support/1.13

Posted by Mark Hanson <ha...@vmware.com>.
Hi All, 

I can't remember for sure, but I think we need 3 approvals?

Thanks,
Mark

On 8/13/20, 4:22 PM, "Owen Nichols" <on...@vmware.com> wrote:

    +1 from me.  Pipeline and all other testing I've seen suggests this fix is good

    On 8/12/20, 4:52 PM, "Jianxia Chen" <jc...@apache.org> wrote:

        +1

        On Wed, Aug 12, 2020 at 4:41 PM Mark Hanson <ha...@vmware.com> wrote:

        > Hi All,
        >
        > We have found a case where tombstones were being cleared when the region
        > was not initialized. This was causing some test failures and potential
        > field failures. We would like to put this into support/1.13.
        >
        > Thanks,
        > Mark
        >



Re: [Proposal] Backport GEODE-8422 to support/1.13

Posted by Owen Nichols <on...@vmware.com>.
+1 from me.  Pipeline and all other testing I've seen suggests this fix is good

On 8/12/20, 4:52 PM, "Jianxia Chen" <jc...@apache.org> wrote:

    +1

    On Wed, Aug 12, 2020 at 4:41 PM Mark Hanson <ha...@vmware.com> wrote:

    > Hi All,
    >
    > We have found a case where tombstones were being cleared when the region
    > was not initialized. This was causing some test failures and potential
    > field failures. We would like to put this into support/1.13.
    >
    > Thanks,
    > Mark
    >


Re: [Proposal] Backport GEODE-8422 to support/1.13

Posted by Mark Hanson <ha...@vmware.com>.
Actually what I should say is that this does not entirely fix GEODE-8422 it reduces the frequency to 1/3 of what it was and fixes one issue of GEODE-8422. It is my understanding we didn't want to hold this release for the other part of this issue. I will file that under a separate bug.

Thanks,
Mark

On 8/13/20, 9:29 AM, "Mark Hanson" <ha...@vmware.com> wrote:

    Yes.

    On 8/13/20, 7:27 AM, "Dave Barnes" <db...@apache.org> wrote:

        Do I understand correctly that this fix, if validated, addresses the last
        remaining release-blocker for 1.13?

        On Wed, Aug 12, 2020 at 6:02 PM Mark Hanson <ha...@vmware.com> wrote:

        > Not yet, we will need to wait for that to finish cleanly relative to this
        > change. I guess I was just seeking to gain approval for priority of it once
        > it does pass. (Maybe I am being a little over zealous).
        >
        > Thanks,
        > Mark
        >
        > On 8/12/20, 5:52 PM, "Dave Barnes" <db...@apache.org> wrote:
        >
        >     Has the version on the develop branch completed a test cycle?
        >
        >     On Wed, Aug 12, 2020 at 4:52 PM Jianxia Chen <jc...@apache.org>
        > wrote:
        >
        >     > +1
        >     >
        >     > On Wed, Aug 12, 2020 at 4:41 PM Mark Hanson <ha...@vmware.com>
        > wrote:
        >     >
        >     > > Hi All,
        >     > >
        >     > > We have found a case where tombstones were being cleared when the
        > region
        >     > > was not initialized. This was causing some test failures and
        > potential
        >     > > field failures. We would like to put this into support/1.13.
        >     > >
        >     > > Thanks,
        >     > > Mark
        >     > >
        >     >
        >
        >



Re: [Proposal] Backport GEODE-8422 to support/1.13

Posted by Mark Hanson <ha...@vmware.com>.
Yes.

On 8/13/20, 7:27 AM, "Dave Barnes" <db...@apache.org> wrote:

    Do I understand correctly that this fix, if validated, addresses the last
    remaining release-blocker for 1.13?

    On Wed, Aug 12, 2020 at 6:02 PM Mark Hanson <ha...@vmware.com> wrote:

    > Not yet, we will need to wait for that to finish cleanly relative to this
    > change. I guess I was just seeking to gain approval for priority of it once
    > it does pass. (Maybe I am being a little over zealous).
    >
    > Thanks,
    > Mark
    >
    > On 8/12/20, 5:52 PM, "Dave Barnes" <db...@apache.org> wrote:
    >
    >     Has the version on the develop branch completed a test cycle?
    >
    >     On Wed, Aug 12, 2020 at 4:52 PM Jianxia Chen <jc...@apache.org>
    > wrote:
    >
    >     > +1
    >     >
    >     > On Wed, Aug 12, 2020 at 4:41 PM Mark Hanson <ha...@vmware.com>
    > wrote:
    >     >
    >     > > Hi All,
    >     > >
    >     > > We have found a case where tombstones were being cleared when the
    > region
    >     > > was not initialized. This was causing some test failures and
    > potential
    >     > > field failures. We would like to put this into support/1.13.
    >     > >
    >     > > Thanks,
    >     > > Mark
    >     > >
    >     >
    >
    >


Re: [Proposal] Backport GEODE-8422 to support/1.13

Posted by Dave Barnes <db...@apache.org>.
Do I understand correctly that this fix, if validated, addresses the last
remaining release-blocker for 1.13?

On Wed, Aug 12, 2020 at 6:02 PM Mark Hanson <ha...@vmware.com> wrote:

> Not yet, we will need to wait for that to finish cleanly relative to this
> change. I guess I was just seeking to gain approval for priority of it once
> it does pass. (Maybe I am being a little over zealous).
>
> Thanks,
> Mark
>
> On 8/12/20, 5:52 PM, "Dave Barnes" <db...@apache.org> wrote:
>
>     Has the version on the develop branch completed a test cycle?
>
>     On Wed, Aug 12, 2020 at 4:52 PM Jianxia Chen <jc...@apache.org>
> wrote:
>
>     > +1
>     >
>     > On Wed, Aug 12, 2020 at 4:41 PM Mark Hanson <ha...@vmware.com>
> wrote:
>     >
>     > > Hi All,
>     > >
>     > > We have found a case where tombstones were being cleared when the
> region
>     > > was not initialized. This was causing some test failures and
> potential
>     > > field failures. We would like to put this into support/1.13.
>     > >
>     > > Thanks,
>     > > Mark
>     > >
>     >
>
>

Re: [Proposal] Backport GEODE-8422 to support/1.13

Posted by Mark Hanson <ha...@vmware.com>.
Not yet, we will need to wait for that to finish cleanly relative to this change. I guess I was just seeking to gain approval for priority of it once it does pass. (Maybe I am being a little over zealous).

Thanks,
Mark

On 8/12/20, 5:52 PM, "Dave Barnes" <db...@apache.org> wrote:

    Has the version on the develop branch completed a test cycle?

    On Wed, Aug 12, 2020 at 4:52 PM Jianxia Chen <jc...@apache.org> wrote:

    > +1
    >
    > On Wed, Aug 12, 2020 at 4:41 PM Mark Hanson <ha...@vmware.com> wrote:
    >
    > > Hi All,
    > >
    > > We have found a case where tombstones were being cleared when the region
    > > was not initialized. This was causing some test failures and potential
    > > field failures. We would like to put this into support/1.13.
    > >
    > > Thanks,
    > > Mark
    > >
    >


Re: [Proposal] Backport GEODE-8422 to support/1.13

Posted by Dave Barnes <db...@apache.org>.
Has the version on the develop branch completed a test cycle?

On Wed, Aug 12, 2020 at 4:52 PM Jianxia Chen <jc...@apache.org> wrote:

> +1
>
> On Wed, Aug 12, 2020 at 4:41 PM Mark Hanson <ha...@vmware.com> wrote:
>
> > Hi All,
> >
> > We have found a case where tombstones were being cleared when the region
> > was not initialized. This was causing some test failures and potential
> > field failures. We would like to put this into support/1.13.
> >
> > Thanks,
> > Mark
> >
>

Re: [Proposal] Backport GEODE-8422 to support/1.13

Posted by Jianxia Chen <jc...@apache.org>.
+1

On Wed, Aug 12, 2020 at 4:41 PM Mark Hanson <ha...@vmware.com> wrote:

> Hi All,
>
> We have found a case where tombstones were being cleared when the region
> was not initialized. This was causing some test failures and potential
> field failures. We would like to put this into support/1.13.
>
> Thanks,
> Mark
>