[GitHub] [spark] cloud-fan commented on a diff in pull request #40851: [SPARK-43190][SQL] ListQuery.childOutput should be consistent with child output

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #40851:
URL: https://github.com/apache/spark/pull/40851#discussion_r1171297009


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala:
##########
@@ -1500,4 +1500,28 @@ class AnalysisSuite extends AnalysisTest with Matchers {
       assert(refs.map(_.output).distinct.length == 3)
     }
   }
+
+  test("SPARK-43190: ListQuery.childOutput should be consistent with child output") {
+    val listQuery1 = ListQuery(testRelation2.select($"a"))
+    val listQuery2 = ListQuery(testRelation2.select($"b"))
+    val plan = testRelation3.where($"f".in(listQuery1) && $"f".in(listQuery2)).analyze
+    val resolvedCondition = plan.expressions.head
+    val finalPlan = testRelation2.join(testRelation3).where(resolvedCondition).analyze

Review Comment:
   The test uses the resolved `ListQuery` to build a new plan and resolve it, to trigger the bug. Otherwise the bug is hidden because `DeduplicateRelations` runs before `ResolveSubqueries`, and the plan output of `ListQuery` won't be changed again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org