You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by ckadner <gi...@git.apache.org> on 2017/10/10 23:58:17 UTC

[GitHub] bahir pull request #51: [BAHIR-139] Force scala-maven-plugin to use java.ver...

GitHub user ckadner opened a pull request:

    https://github.com/apache/bahir/pull/51

    [BAHIR-139] Force scala-maven-plugin to use java.version

    Make sure the *scala-maven-plugin* uses `${java.version}` `1.8` instead of the
    default which is Java version `1.6`.
    
    Also upgrading the scala-maven-plugin version from `3.2.2` to `3.3.1`
    
    JIRA: [BAHIR-139](https://issues.apache.org/jira/browse/BAHIR-139)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ckadner/bahir BAHIR-139_scala-maven-plugin_Java_compile_version

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bahir/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #51
    
----
commit 1b3848f26956f32712b62d28b2abf0182d072c8f
Author: Christian Kadner <ck...@us.ibm.com>
Date:   2017-10-10T23:54:36Z

    [BAHIR-139] Force scala-maven-plugin to use java.version
    
    Make sure the scala-maven-plugin uses java.version 1.8 instead of the
    default which is Java 1.6.
    
    Also upgrading the scala-maven-plugin version from 3.2.2 to 3.3.1
    
    Closes #51

----


---

[GitHub] bahir pull request #51: [BAHIR-139] Force scala-maven-plugin to use java.ver...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/bahir/pull/51


---

[GitHub] bahir issue #51: [BAHIR-139] Force scala-maven-plugin to use java.version 1....

Posted by ApacheBahir <gi...@git.apache.org>.
Github user ApacheBahir commented on the issue:

    https://github.com/apache/bahir/pull/51
  
    Build successful
     



---

[GitHub] bahir issue #51: [BAHIR-139] Force scala-maven-plugin to use java.version 1....

Posted by emlaver <gi...@git.apache.org>.
Github user emlaver commented on the issue:

    https://github.com/apache/bahir/pull/51
  
    +1 looks good


---

[GitHub] bahir issue #51: [BAHIR-139] Force scala-maven-plugin to use java.version 1....

Posted by ckadner <gi...@git.apache.org>.
Github user ckadner commented on the issue:

    https://github.com/apache/bahir/pull/51
  
    ok to test


---

[GitHub] bahir issue #51: [BAHIR-139] Force scala-maven-plugin to use java.version 1....

Posted by ApacheBahir <gi...@git.apache.org>.
Github user ApacheBahir commented on the issue:

    https://github.com/apache/bahir/pull/51
  
    
    Refer to this link for build results (access rights to CI server needed): 
    http://169.45.79.58:8080/job/bahir_spark_pr_builder/105/



---