You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ne...@apache.org on 2017/07/05 22:57:15 UTC
mesos git commit: Improved the documentation of 'TASK_LOST'.
Repository: mesos
Updated Branches:
refs/heads/master 08f6b428f -> df27b4922
Improved the documentation of 'TASK_LOST'.
Updated the protobuf comments to clarify that 'TASK_LOST' is not
always a terminal state.
Review: https://reviews.apache.org/r/60346/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/df27b492
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/df27b492
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/df27b492
Branch: refs/heads/master
Commit: df27b49227d17f7d9c11f5c213ef3e89eda9cbaf
Parents: 08f6b42
Author: Gastón Kleiman <ga...@mesosphere.io>
Authored: Wed Jul 5 15:54:00 2017 -0700
Committer: Neil Conway <ne...@gmail.com>
Committed: Wed Jul 5 15:56:49 2017 -0700
----------------------------------------------------------------------
include/mesos/mesos.proto | 12 ++++++++----
include/mesos/v1/mesos.proto | 12 ++++++++----
2 files changed, 16 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/df27b492/include/mesos/mesos.proto
----------------------------------------------------------------------
diff --git a/include/mesos/mesos.proto b/include/mesos/mesos.proto
index 4e4b279..ab2a372 100644
--- a/include/mesos/mesos.proto
+++ b/include/mesos/mesos.proto
@@ -65,8 +65,8 @@ message SlaveID {
* A framework-generated ID to distinguish a task. The ID must remain
* unique while the task is active. A framework can reuse an ID _only_
* if the previous task with the same ID has reached a terminal state
- * (e.g., TASK_FINISHED, TASK_LOST, TASK_KILLED, etc.). However,
- * reusing task IDs is strongly discouraged (MESOS-2198).
+ * (e.g., TASK_FINISHED, TASK_KILLED, etc.). However, reusing task IDs
+ * is strongly discouraged (MESOS-2198).
*/
message TaskID {
required string value = 1;
@@ -1954,9 +1954,13 @@ enum TaskState {
// In Mesos 1.3, this will only be sent when the framework does NOT
// opt-in to the PARTITION_AWARE capability.
- TASK_LOST = 5; // TERMINAL: The task failed but can be rescheduled.
+ //
+ // NOTE: This state is not always terminal. For example, tasks might
+ // transition from TASK_LOST to TASK_RUNNING or other states when a
+ // partitioned agent re-registers.
+ TASK_LOST = 5; // The task failed but can be rescheduled.
- // The following task statuses are only sent when the framework
+ // The following task states are only sent when the framework
// opts-in to the PARTITION_AWARE capability.
// The task failed to launch because of a transient error. The
http://git-wip-us.apache.org/repos/asf/mesos/blob/df27b492/include/mesos/v1/mesos.proto
----------------------------------------------------------------------
diff --git a/include/mesos/v1/mesos.proto b/include/mesos/v1/mesos.proto
index b8625d3..5e92e5d 100644
--- a/include/mesos/v1/mesos.proto
+++ b/include/mesos/v1/mesos.proto
@@ -65,8 +65,8 @@ message AgentID {
* A framework-generated ID to distinguish a task. The ID must remain
* unique while the task is active. A framework can reuse an ID _only_
* if the previous task with the same ID has reached a terminal state
- * (e.g., TASK_FINISHED, TASK_LOST, TASK_KILLED, etc.). However,
- * reusing task IDs is strongly discouraged (MESOS-2198).
+ * (e.g., TASK_FINISHED, TASK_KILLED, etc.). However, reusing task IDs
+ * is strongly discouraged (MESOS-2198).
*/
message TaskID {
required string value = 1;
@@ -1937,9 +1937,13 @@ enum TaskState {
// In Mesos 1.3, this will only be sent when the framework does NOT
// opt-in to the PARTITION_AWARE capability.
- TASK_LOST = 5; // TERMINAL: The task failed but can be rescheduled.
+ //
+ // NOTE: This state is not always terminal. For example, tasks might
+ // transition from TASK_LOST to TASK_RUNNING or other states when a
+ // partitioned agent re-registers.
+ TASK_LOST = 5; // The task failed but can be rescheduled.
- // The following task statuses are only sent when the framework
+ // The following task states are only sent when the framework
// opts-in to the PARTITION_AWARE capability.
// The task failed to launch because of a transient error. The