You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/06/12 00:12:36 UTC

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4913: Fix 4 high priority bugs

codecov[bot] edited a comment on pull request #4913:
URL: https://github.com/apache/skywalking/pull/4913#issuecomment-642794034


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4913?src=pr&el=h1) Report
   > Merging [#4913](https://codecov.io/gh/apache/skywalking/pull/4913?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7b99019c491ee129a5f95daa19efe9013d4e9e9d&el=desc) will **increase** coverage by `1.12%`.
   > The diff coverage is `63.15%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4913/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4913?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4913      +/-   ##
   ============================================
   + Coverage     50.11%   51.24%   +1.12%     
   - Complexity     2743     2745       +2     
   ============================================
     Files           762     1350     +588     
     Lines         18855    29412   +10557     
     Branches       1848     3239    +1391     
   ============================================
   + Hits           9449    15071    +5622     
   - Misses         8650    13627    +4977     
   + Partials        756      714      -42     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4913?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rage/plugin/jdbc/h2/dao/H2TopNRecordsQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4913/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVG9wTlJlY29yZHNRdWVyeURBTy5qYXZh) | `8.57% <0.00%> (-0.26%)` | `1.00 <0.00> (ø)` | |
   | [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4913/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `81.33% <70.58%> (+1.33%)` | `14.00 <0.00> (+2.00)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4913/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4913/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
   | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4913/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
   | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/4913/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
   | [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/4913/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
   | [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/4913/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/4913/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
   | [...ticsearch7/client/ElasticSearch7InsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/4913/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdJbnNlcnRSZXF1ZXN0LmphdmE=) | `83.33% <0.00%> (-16.67%)` | `2.00% <0.00%> (ø%)` | |
   | ... and [919 more](https://codecov.io/gh/apache/skywalking/pull/4913/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4913?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4913?src=pr&el=footer). Last update [7b99019...9975080](https://codecov.io/gh/apache/skywalking/pull/4913?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org