(causeway) 32/39: CAUSEWAY-4012: renames selector action prefix

[da...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

danhaywood pushed a commit to branch CAUSEWAY-4012
in repository https://gitbox.apache.org/repos/asf/causeway.git

commit e8ad5f96922134e590dfa3486485e65fb0e43dd6
Author: Dan Haywood <da...@haywood-associates.co.uk>
AuthorDate: Sat Jun 6 06:28:38 2026 +0100

    CAUSEWAY-4012: renames selector action prefix
---
 .../specloader/specimpl/ObjectSpecificationAbstract.java     |  2 +-
 .../specimpl/ParentedCollectionSelectorActionUtilTest.java   |  5 +++--
 .../changes/rename-selector-prefix-to-select-from/tasks.md   | 12 ++++++------
 3 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/specloader/specimpl/ObjectSpecificationAbstract.java b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/specloader/specimpl/ObjectSpecificationAbstract.java
index 8900d79e828..f10ee8a64ad 100644
--- a/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/specloader/specimpl/ObjectSpecificationAbstract.java
+++ b/core/metamodel/src/main/java/org/apache/causeway/core/metamodel/specloader/specimpl/ObjectSpecificationAbstract.java
@@ -1025,7 +1025,7 @@ protected boolean isRecordingSupportEnabled() {
     @UtilityClass
     public static class ParentedCollectionSelectorActionUtil {
 
-        public static final String ACTION_ID_PREFIX = "__causeway_select_";
+        public static final String ACTION_ID_PREFIX = "__causeway_select_from_";
 
         private static final Set<String> EXCLUDED_PARAMETER_PROPERTY_IDS = Set.of(
                 "logicalTypeName",
diff --git a/core/metamodel/src/test/java/org/apache/causeway/core/metamodel/specloader/specimpl/ParentedCollectionSelectorActionUtilTest.java b/core/metamodel/src/test/java/org/apache/causeway/core/metamodel/specloader/specimpl/ParentedCollectionSelectorActionUtilTest.java
index b01781c2a5c..2ed85ad5c06 100644
--- a/core/metamodel/src/test/java/org/apache/causeway/core/metamodel/specloader/specimpl/ParentedCollectionSelectorActionUtilTest.java
+++ b/core/metamodel/src/test/java/org/apache/causeway/core/metamodel/specloader/specimpl/ParentedCollectionSelectorActionUtilTest.java
@@ -176,7 +176,8 @@ void does_not_synthesize_selector_action_unless_enabled() {
 
     @Test
     void synthesizes_selector_action_with_marker_and_safe_semantics_when_enabled() {
-        assertThat(selectorAction.getId(), is(ObjectSpecificationAbstract.ParentedCollectionSelectorActionUtil.ACTION_ID_PREFIX + "items"));
+        assertThat(ObjectSpecificationAbstract.ParentedCollectionSelectorActionUtil.ACTION_ID_PREFIX, is("__causeway_select_from_"));
+        assertThat(selectorAction.getId(), is("__causeway_select_from_items"));
         MatcherAssert.assertThat(selectorAction.getFacet(ParentedCollectionSelectorFacet.class), instanceOf(ParentedCollectionSelectorFacetDefault.class));
         assertThat(selectorAction.getSemantics(), is(SemanticsOf.SAFE));
         assertThat(selectorAction.getFacet(CommandPublishingFacet.class).isEnabled(), is(true));
@@ -193,7 +194,7 @@ void associates_selector_action_with_parented_collection() {
 
     @Test
     void names_selector_action_select_while_preserving_deterministic_id() {
-        assertThat(selectorAction.getId(), is(ObjectSpecificationAbstract.ParentedCollectionSelectorActionUtil.ACTION_ID_PREFIX + "items"));
+        assertThat(selectorAction.getId(), is("__causeway_select_from_items"));
         assertThat(selectorAction.getCanonicalFriendlyName(), is("Select"));
     }
 
diff --git a/openspec/changes/rename-selector-prefix-to-select-from/tasks.md b/openspec/changes/rename-selector-prefix-to-select-from/tasks.md
index 1b32d532fa8..12c529e9a73 100644
--- a/openspec/changes/rename-selector-prefix-to-select-from/tasks.md
+++ b/openspec/changes/rename-selector-prefix-to-select-from/tasks.md
@@ -1,14 +1,14 @@
 ## 1. Implementation
 
-- [ ] 1.1 Update the synthetic parented collection selector action id prefix constant from `__causeway_select_` to `__causeway_select_from_`.
-- [ ] 1.2 Verify selector action id construction still appends the associated parented collection id without changing display name, layout association, parameters, or invocation behavior.
+- [x] 1.1 Update the synthetic parented collection selector action id prefix constant from `__causeway_select_` to `__causeway_select_from_`.
+- [x] 1.2 Verify selector action id construction still appends the associated parented collection id without changing display name, layout association, parameters, or invocation behavior.
 
 ## 2. Tests and Documentation
 
-- [ ] 2.1 Update selector action unit tests and any fixtures that assert the old `__causeway_select_` prefix.
-- [ ] 2.2 Search source, tests, and OpenSpec artifacts for remaining references to the old prefix and update only the references that describe current behavior.
+- [x] 2.1 Update selector action unit tests and any fixtures that assert the old `__causeway_select_` prefix.
+- [x] 2.2 Search source, tests, and OpenSpec artifacts for remaining references to the old prefix and update only the references that describe current behavior.
 
 ## 3. Validation
 
-- [ ] 3.1 Run the focused selector action test suite for `ParentedCollectionSelectorActionUtilTest`.
-- [ ] 3.2 Run `openspec validate rename-selector-prefix-to-select-from --strict`.
+- [x] 3.1 Run the focused selector action test suite for `ParentedCollectionSelectorActionUtilTest`.
+- [x] 3.2 Run `openspec validate rename-selector-prefix-to-select-from --strict`.