You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/26 16:15:36 UTC
[GitHub] [nuttx] anchao opened a new pull request, #7703: net/devif: add common funtion to handle L2 packet
anchao opened a new pull request, #7703:
URL: https://github.com/apache/nuttx/pull/7703
## Summary
net/devif: add common funtion to handle L2 packet
Handle an L2 packet from the network device. Verify and forward to
L3 packet handling logic if the packet is destined for us.
## Impact
N/A
## Testing
ci check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #7703: net/devif/ip: build l2 header on the IP layer
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7703:
URL: https://github.com/apache/nuttx/pull/7703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] anchao commented on a diff in pull request #7703: net/devif/ip: build l2 header on the IP layer
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #7703:
URL: https://github.com/apache/nuttx/pull/7703#discussion_r1032824000
##########
arch/arm/src/c5471/c5471_ethernet.c:
##########
@@ -1338,21 +1338,6 @@ static void c5471_receive(struct c5471_driver_s *priv)
if (dev->d_len > 0 &&
(EIM_TXDESC_OWN_HOST & getreg32(priv->c_rxcpudesc)) == 0)
{
- /* Update the Ethernet header with the correct MAC address */
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7703: net/devif/ip: build l2 header on the IP layer
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7703:
URL: https://github.com/apache/nuttx/pull/7703#discussion_r1032821895
##########
arch/arm/src/c5471/c5471_ethernet.c:
##########
@@ -1338,21 +1338,6 @@ static void c5471_receive(struct c5471_driver_s *priv)
if (dev->d_len > 0 &&
(EIM_TXDESC_OWN_HOST & getreg32(priv->c_rxcpudesc)) == 0)
{
- /* Update the Ethernet header with the correct MAC address */
Review Comment:
let's move arp_ipin at line 1320 into to ipv4_input
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] anchao commented on a diff in pull request #7703: net/devif/ip: build l2 header on the IP layer
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #7703:
URL: https://github.com/apache/nuttx/pull/7703#discussion_r1032822109
##########
arch/arm/src/gd32f4/gd32f4xx_enet.c:
##########
@@ -1718,10 +1718,6 @@ static void gd32_receive(struct gd32_enet_mac_s *priv)
if (priv->dev.d_len > 0)
{
- /* Update the Ethernet header with the correct MAC address */
-
- arp_out(&priv->dev);
Review Comment:
Depends on https://github.com/apache/nuttx/pull/7701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7703: net/devif/ip: build l2 header on the IP layer
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7703:
URL: https://github.com/apache/nuttx/pull/7703#discussion_r1032821656
##########
arch/arm/src/gd32f4/gd32f4xx_enet.c:
##########
@@ -1718,10 +1718,6 @@ static void gd32_receive(struct gd32_enet_mac_s *priv)
if (priv->dev.d_len > 0)
{
- /* Update the Ethernet header with the correct MAC address */
-
- arp_out(&priv->dev);
Review Comment:
let's move arp_out/neighbor_out prototype to net/arp/arp.h and net/neighbor/neighbor.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org