[GitHub] [skywalking] wu-sheng commented on a change in pull request #5088: fix config file and document typo for ttl (#5087)

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #5088:
URL: https://github.com/apache/skywalking/pull/5088#discussion_r453271434



##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -66,7 +66,7 @@ core:
     enableDataKeeperExecutor: ${SW_CORE_ENABLE_DATA_KEEPER_EXECUTOR:true} # Turn it off then automatically metrics data delete will be close.
     dataKeeperExecutePeriod: ${SW_CORE_DATA_KEEPER_EXECUTE_PERIOD:5} # How often the data keeper executor runs periodically, unit is minute
     recordDataTTL: ${SW_CORE_RECORD_DATA_TTL:3} # Unit is day
-    metricsDataTTL: ${SW_CORE_RECORD_DATA_TTL:7} # Unit is day
+    metricsDataTTL: ${SW_CORE_METRICS_DATA_TTL:7} # Unit is day

Review comment:
       FYI @innerpeacez Notice, this change should be included in the helm next release.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org