[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4222: Add startup/shutdown checks for HelixServerStarter
URL: https://github.com/apache/incubator-pinot/pull/4222#discussion_r285773257
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
 ##########
 @@ -171,13 +171,8 @@ public ServerType getServerType() {
     public static final String CONFIG_OF_REQUEST_HANDLER_FACTORY_CLASS = "pinot.server.requestHandlerFactory.class";
     public static final String CONFIG_OF_NETTY_PORT = "pinot.server.netty.port";
     public static final String CONFIG_OF_ADMIN_API_PORT = "pinot.server.adminapi.port";
-    public static final String CONFIG_OF_STARTER_ENABLE_SEGMENTS_LOADING_CHECK =
 
 Review comment:
   IMO we should not keep unused constants in the code base, it's better to put them in the release log.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org