You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2008/06/13 09:40:00 UTC
[jira] Created: (CAMEL-606) JMX enabled as default
JMX enabled as default
----------------------
Key: CAMEL-606
URL: https://issues.apache.org/activemq/browse/CAMEL-606
Project: Apache Camel
Issue Type: Wish
Components: camel-core
Affects Versions: 1.3.0, 1.4.0
Reporter: Claus Ibsen
Fix For: 1.4.0
> Hi
>
> Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
Yeah, I think we should.
> What is the default in ServiceMix? Maybe Camel should align what they do?
AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
--
James
-------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-606) JMX enabled as default
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43615#action_43615 ]
Claus Ibsen commented on CAMEL-606:
-----------------------------------
Could we improve the DEBUG/INFO logging when the JMX stuff is started / registered?
End-users should be able to find the URI endpoints etc. at INFO level how to connect to the camel context.
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Fix For: 1.4.0
>
> Attachments: patch.txt
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-606) JMX enabled as default
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43610#action_43610 ]
Claus Ibsen commented on CAMEL-606:
-----------------------------------
William Tam - thanks a lot for the great patch. This is awesome work. You did go all the way - started with an issue to enable jmx and then discovered more and more that could/should be fixed. That is great that you have this talent and wanted to contribute it back. Thanks a lot ;)
Looking forward for the wiki documentation as well - that is where the frameworks put themselves into a higher level if the documentation is concise and up to date.
Since its a big patch I do think we test the JMX stuff a bit more a final 1.4 can be released.
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Fix For: 1.4.0
>
> Attachments: patch.txt
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-606) JMX enabled as default
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-606:
---------------------------------
Assignee: Claus Ibsen
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-606) JMX enabled as default
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43622#action_43622 ]
Willem Jiang commented on CAMEL-606:
------------------------------------
Done, removed the CamelChoiceWithManagementTest from SVN.
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Fix For: 1.4.0
>
> Attachments: patch.txt
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-606) JMX enabled as default
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43457#action_43457 ]
William Tam commented on CAMEL-606:
-----------------------------------
I'm working on it.
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Fix For: 1.4.0
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-606) JMX enabled as default
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43464#action_43464 ]
Claus Ibsen commented on CAMEL-606:
-----------------------------------
William is again busy working on patch for Camel ;)
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-606) JMX enabled as default
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Tam updated CAMEL-606:
------------------------------
Attachment: CamelChoiceWithManagementTest.java.patch
Sorry, CamelChoiceWithManagementTest.java was missing from my patch. Here is it.
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Fix For: 1.4.0
>
> Attachments: CamelChoiceWithManagementTest.java.patch, patch.txt
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-606) JMX enabled as default
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43637#action_43637 ]
Claus Ibsen commented on CAMEL-606:
-----------------------------------
William, thanks for the missing unit test. Its not added to the trunk.
The unit test passed on my local laptop.
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: CamelChoiceWithManagementTest.java.patch, patch.txt
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-606) JMX enabled as default
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-606:
----------------------------------
Assignee: Willem Jiang (was: Claus Ibsen)
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Fix For: 1.4.0
>
> Attachments: patch.txt
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-606) JMX enabled as default
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea reassigned CAMEL-606:
-------------------------------------
Assignee: Hadrian Zbarcea (was: Willem Jiang)
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: CamelChoiceWithManagementTest.java.patch, patch.txt
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-606) JMX enabled as default
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43637#action_43637 ]
davsclaus edited comment on CAMEL-606 at 6/22/08 8:53 PM:
------------------------------------------------------------
William, thanks for the missing unit test. Its *now* added to the trunk.
The unit test passed on my local laptop.
was (Author: davsclaus):
William, thanks for the missing unit test. Its not added to the trunk.
The unit test passed on my local laptop.
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: CamelChoiceWithManagementTest.java.patch, patch.txt
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-606) JMX enabled as default
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Tam updated CAMEL-606:
------------------------------
Attachment: patch.txt
I will update wiki once this patch has been applied.
* By default, Camel mbean objects are registered with a mbean server and performance counters are enabled. However, RMI connector server is not started by default.
* Mbean server is "found" by mbean server's default domain name as it can be shared among camel contexts and with other application when it is desirable (as mentioned in CAMEL-613).
* If no mbean server can be found, a new one will be created.
* As before, it is also possible to use the platform mbean server.
* System properties (found in JmxSystemPropertyKeys.java) and Spring configuration (found in CamelJMXAgentType.java) support the same set of configuration parameters.
* Instrumentation agent can be disabled by system property or spring configuration.
* Default Instrumentation agent is started and stop by the camel context as a service eliminating the need for SpringInstrumentationAgent subclass.
* Moved CamelChoiceWithManagementTest from spring to core where it belongs
* updated RouteBuilderTest, ErrorHandlerTest to account for instrumentation interceptors
* Fixed some of the JMX tests that does not clear and restore system properties properly and release mbean servers at the end of the test.
* Update AggregatorType to allow it to be wrapped by interceptors.
* add ErrorHandlerWrappingStrategy mechanism as we need to prevent instrumentation interceptor from being wrapped by ErrorHandlers.
* rename LifecycleStrategy.onContextAdd() to onContextStart() since the lifecycle strategy is typically created after camel context. Therefore, we are not really able to invoke the lifecycle strategy at that time. It's more meaningful to be notified when camel context is started instead.
* since the default domain name for the mbean server and the domain name of the registered mbean object can be differ, we make them into different properties.
* Add a check in ProcessorType.wrapProcessorInInterceptors() to prevent intercept ref from changing target processor. It is a potential cycling problem. This problem is discovered by enabling instrumentaton interceptor in StreamCachingInterceptorTest. We'll probably should revisit StreamCachingInterceptor. I'll create a JIRA.
* workaround NPE (CAMEL-620) in ResequencerType to allow createProcesssor to be invoked (so we can wrap Resequencer by an interceptor).
* add async support for InstrumentationProcessor
* Fix CAMEL-553 (Firewall-friendly JMX Connector URL) by adding a property for RMI connection port.
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
> Attachments: patch.txt
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-606) JMX enabled as default
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea resolved CAMEL-606.
-----------------------------------
Resolution: Fixed
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Hadrian Zbarcea
> Fix For: 1.4.0
>
> Attachments: CamelChoiceWithManagementTest.java.patch, patch.txt
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-606) JMX enabled as default
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43608#action_43608 ]
Willem Jiang commented on CAMEL-606:
------------------------------------
Hi William,
Thanks for your contribution. It's a huge patch, I will take some time to review it .
Claus, I take this task for getting the patch into repository ASAP :)
Willem
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Fix For: 1.4.0
>
> Attachments: patch.txt
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (CAMEL-606) JMX enabled as default
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on CAMEL-606 started by Claus Ibsen.
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-606) JMX enabled as default
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43616#action_43616 ]
Claus Ibsen commented on CAMEL-606:
-----------------------------------
This unit test CamelChoiceWithManagementTest file is 0 in file size. Maybe it should be deleted from SVN.
> JMX enabled as default
> ----------------------
>
> Key: CAMEL-606
> URL: https://issues.apache.org/activemq/browse/CAMEL-606
> Project: Apache Camel
> Issue Type: Wish
> Components: camel-core
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Fix For: 1.4.0
>
> Attachments: patch.txt
>
>
> > Hi
> >
> > Should we consider enabling JMX as default in Camel? It runs on JDK1.5 and thus its possible.
> Yeah, I think we should.
> > What is the default in ServiceMix? Maybe Camel should align what they do?
> AFAIK ServiceMix and ActiveMQ default it to true. Folk should have to disable it IMHO as its so useful
> --
> James
> -------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.