You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2018/11/15 13:20:59 UTC
[GitHub] carbondata pull request #2926: [HOTFIX] Reduce blocklet minimum configurable...
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2926
[HOTFIX] Reduce blocklet minimum configurable size
In case of point queries, it would be better to create less blocklet size to read less data. So reducing the minimum blocklet size limit to 1 MB.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/incubator-carbondata reduce-blocklet-min-size
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2926.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2926
----
commit 031ea96d4497392227711b21419212e186c18cc2
Author: ravipesala <ra...@...>
Date: 2018-11-15T13:19:19Z
Reduce blocklet minimum configurable size
----
---
[GitHub] carbondata issue #2926: [HOTFIX] Reduce blocklet minimum configurable size
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2926
LGTM
---
[GitHub] carbondata pull request #2926: [HOTFIX] Reduce blocklet minimum configurable...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2926
---
[GitHub] carbondata issue #2926: [HOTFIX] Reduce blocklet minimum configurable size
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2926
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9697/
---
[GitHub] carbondata issue #2926: [HOTFIX] Reduce blocklet minimum configurable size
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2926
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1439/
---
[GitHub] carbondata pull request #2926: [HOTFIX] Reduce blocklet minimum configurable...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2926#discussion_r234399060
--- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonV3DataFormatConstants.java ---
@@ -35,9 +35,9 @@
String BLOCKLET_SIZE_IN_MB_DEFAULT_VALUE = "64";
/**
- * blocklet group size min value
+ * blocklet size min value
--- End diff --
since you are modifying this, can you please modify line 33, 27 also
---
[GitHub] carbondata issue #2926: [HOTFIX] Reduce blocklet minimum configurable size
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2926
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9682/
---
[GitHub] carbondata issue #2926: [HOTFIX] Reduce blocklet minimum configurable size
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2926
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1425/
---
[GitHub] carbondata issue #2926: [HOTFIX] Reduce blocklet minimum configurable size
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2926
Will it be a table property or just leave it as a system property?
---
[GitHub] carbondata issue #2926: [HOTFIX] Reduce blocklet minimum configurable size
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2926
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1634/
---
[GitHub] carbondata issue #2926: [HOTFIX] Reduce blocklet minimum configurable size
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2926
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1649/
---
[GitHub] carbondata issue #2926: [HOTFIX] Reduce blocklet minimum configurable size
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2926
`table_blocklet_size` is a table property that can be used in create table
---