You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2017/04/21 16:32:04 UTC

[jira] [Resolved] (NET-636) examples should be in org.apache.commons.net subpackage

     [ https://issues.apache.org/jira/browse/NET-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved NET-636.
----------------------
       Resolution: Fixed
    Fix Version/s: 3.7

URL: http://svn.apache.org/viewvc?rev=1792230&view=rev
Log:
NET-636 examples should be in org.apache.commons.net subpackage

Added:
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/
      - copied from r1792229, commons/proper/net/trunk/src/main/java/examples/
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/package-info.java   (with props)
    commons/proper/net/trunk/src/main/resources/org/
    commons/proper/net/trunk/src/main/resources/org/apache/
    commons/proper/net/trunk/src/main/resources/org/apache/commons/
    commons/proper/net/trunk/src/main/resources/org/apache/commons/net/
    commons/proper/net/trunk/src/main/resources/org/apache/commons/net/examples/
      - copied from r1792229, commons/proper/net/trunk/src/main/resources/examples/
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/examples/
      - copied from r1792229, commons/proper/net/trunk/src/test/java/examples/
Removed:
    commons/proper/net/trunk/src/main/java/examples/
    commons/proper/net/trunk/src/main/resources/examples/
    commons/proper/net/trunk/src/test/java/examples/
Modified:
    commons/proper/net/trunk/pom.xml
    commons/proper/net/trunk/src/assembly/bin.xml
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/Main.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/cidr/SubnetUtilsExample.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/ftp/FTPClientExample.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/ftp/ServerToServerFTP.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/ftp/TFTPExample.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/mail/IMAPExportMbox.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/mail/IMAPImportMbox.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/mail/IMAPMail.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/mail/IMAPUtils.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/mail/POP3ExportMbox.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/mail/POP3Mail.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/mail/SMTPMail.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/mail/Utils.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/nntp/ArticleReader.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/nntp/ExtendedNNTPOps.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/nntp/ListNewsgroups.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/nntp/MessageThreading.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/nntp/NNTPUtils.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/nntp/PostMessage.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/ntp/NTPClient.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/ntp/SimpleNTPServer.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/ntp/TimeClient.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/telnet/TelnetClientExample.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/telnet/WeatherTelnet.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/unix/chargen.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/unix/daytime.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/unix/echo.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/unix/finger.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/unix/fwhois.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/unix/rdate.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/unix/rexec.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/unix/rlogin.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/unix/rshell.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/examples/util/IOUtil.java
    commons/proper/net/trunk/src/main/resources/org/apache/commons/net/examples/examples.properties
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/examples/MainTest.java
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TestNtpClient.java


> examples should be in org.apache.commons.net subpackage
> -------------------------------------------------------
>
>                 Key: NET-636
>                 URL: https://issues.apache.org/jira/browse/NET-636
>             Project: Commons Net
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 3.7
>
>
> The examples are currently under the top-level 'examples' package.
> This was fine when they were only documentation samples, but they are now working examples which are published (in a separate jar).
> The package needs to ge changed to be under org.apache.commons.net.
> Given that they are clearly marked as examples, they are not part of the public API (and are not in the standard binary jar). Thus the change will not impact  compatibility of the component proper.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)