[GitHub] mcvsubbu commented on a change in pull request #3856: Check assigned instances for uploading new segment

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #3856: Check assigned instances for uploading new segment
URL: https://github.com/apache/incubator-pinot/pull/3856#discussion_r258710125
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
 ##########
 @@ -1461,10 +1461,11 @@ public PinotResourceManagerResponse dropTable(String tableName) {
   }
 
   public void addNewSegment(@Nonnull SegmentMetadata segmentMetadata, @Nonnull String downloadUrl) {
-    addNewSegment(segmentMetadata, downloadUrl, null);
+    addNewSegment(segmentMetadata, downloadUrl, null, null);
   }
 
-  public void addNewSegment(@Nonnull SegmentMetadata segmentMetadata, @Nonnull String downloadUrl, String crypter) {
+  public void addNewSegment(@Nonnull SegmentMetadata segmentMetadata, @Nonnull String downloadUrl, String crypter,
+      List<String> assignedInstances) {
 
 Review comment:
   mark assigned instances as @ NonNull?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org