You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/29 16:03:32 UTC
[GitHub] [incubator-nuttx] AlanRosenthal opened a new pull request #5116: Remove .clean_context
AlanRosenthal opened a new pull request #5116:
URL: https://github.com/apache/incubator-nuttx/pull/5116
## Summary
These changes are from this PR: https://github.com/apache/incubator-nuttx/pull/5069
However I felt they were better as a stand only change.
## Impact
The `.clean_context` dependency didn't make sense. It was a workaround to ensure that `context` was cleaned when the `.config` changed.
Rather than having a work around, this PR ensures that `clean_context` is run when the `olddefconfig` target is run
## Testing
Verified locally by running: `tools/testbuild.sh -j 100 -e '-Wno-cpp -Werror' tools/ci/testlist/arm-01.dat`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] AlanRosenthal commented on pull request #5116: Remove .clean_context
Posted by GitBox <gi...@apache.org>.
AlanRosenthal commented on pull request #5116:
URL: https://github.com/apache/incubator-nuttx/pull/5116#issuecomment-1002768993
> We don't need the same for `menuconfig` and other such targets?
That's a good point! I read README.md and believe that I've added them to all the relevant targets (pretty much everything except for savedefconfig). Let me know if you believe I'm mistaken anywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5116: Remove .clean_context
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #5116:
URL: https://github.com/apache/incubator-nuttx/pull/5116#issuecomment-1002678398
We don't need the same for `menuconfig` and other such targets?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] AlanRosenthal edited a comment on pull request #5116: Remove .clean_context
Posted by GitBox <gi...@apache.org>.
AlanRosenthal edited a comment on pull request #5116:
URL: https://github.com/apache/incubator-nuttx/pull/5116#issuecomment-1002768993
> We don't need the same for `menuconfig` and other such targets?
That's a good point! I reread README.md and believe that I've added the changes to all the relevant targets (pretty much everything except for savedefconfig). Let me know if you believe I'm mistaken anywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5116: Remove .clean_context
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5116:
URL: https://github.com/apache/incubator-nuttx/pull/5116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org