***UNCHECKED*** Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

[Alexander Rukletsov <ru...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65348/#review196332
-----------------------------------------------------------




src/tests/master_tests.cpp
Lines 8615-8616 (original), 8615-8616 (patched)
<https://reviews.apache.org/r/65348/#comment275901>

    Remove the comment as well!


- Alexander Rukletsov


On Jan. 26, 2018, 12:55 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65348/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2018, 12:55 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8490
>     https://issues.apache.org/jira/browse/MESOS-8490
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Under rare circumstances, the clock would have to be advanced to trigger
> a new allocation cycle after 'UPDATE_SLAVE' has been handled in the
> master. We also wait for old offers to be rescinded before waiting for
> updated offers as sometimes the old offer could be received erroneously.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 4a284c4e9c26b39d1e88b405f8b904f43b902b02 
> 
> 
> Diff: https://reviews.apache.org/r/65348/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> `src/mesos-tests --gtest_filter=MasterTest.UpdateSlaveMessageWithPendingOffers --gtest_repeat=10000 --gtest_break_on_failure` while running `stress -c 4 -i 8 -m 2 -d 6` on a 4 core machine. It usually takes a few thousand iterations to trigger the flakyness in the old code. And only when the host is under heavy load.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>