You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2023/07/26 16:16:37 UTC

[GitHub] [superset] rusackas commented on pull request #23492: bug fix 16481

rusackas commented on PR #23492:
URL: https://github.com/apache/superset/pull/23492#issuecomment-1652127307

   Ok. Let's not do this for now. I've closed the underlying issue that this resolves, as well, since the current behavior is 
   • the more desirable state (left-aligned text, right-aligned numbers for easier comparison)
   • overridable via existing chart controls under "customize"
   
   If anyone finds this controversial (particularly @appasuamithsai ) then we can re-visit this, possibly taking the discussion to the mailing list or another venue for a wider audience. Maybe a path forward would be discussing/considering an additional config or control for this "default alignment" idea. 
   
   We REALLY appreciate your first PR, and despite closing this one, hope you continue to stay engaged with the community and keep making Superset better!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org