You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/07/07 08:15:01 UTC
[GitHub] [solr] uschindler opened a new pull request #205: SOLR-15520: Fix build on windows by downgrading jekyll
uschindler opened a new pull request #205:
URL: https://github.com/apache/solr/pull/205
See issue: https://issues.apache.org/jira/browse/SOLR-15520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] ctargett commented on a change in pull request #205: SOLR-15520: Fix build on windows by downgrading jekyll
Posted by GitBox <gi...@apache.org>.
ctargett commented on a change in pull request #205:
URL: https://github.com/apache/solr/pull/205#discussion_r665294346
##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -67,8 +67,9 @@ dependencies {
depVer('org.apache.tika:tika-core')
depVer('org.apache.zookeeper:zookeeper')
- // jekyll dependencies
- gems 'rubygems:jekyll:4.2.0'
+ // jekyll dependencies: we cannot use jekyll >=4, as this version uses native lib
+ // ("sassc" instead of deprecated "sass") which fails to compile on some platforms
Review comment:
It might not be a bad idea to add a reference to the issue SOLR-15520 in this comment so anyone later can find the discussion of why it doesn't work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on a change in pull request #205: SOLR-15520: Fix build on windows by downgrading jekyll
Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #205:
URL: https://github.com/apache/solr/pull/205#discussion_r665340920
##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -67,8 +67,9 @@ dependencies {
depVer('org.apache.tika:tika-core')
depVer('org.apache.zookeeper:zookeeper')
- // jekyll dependencies
- gems 'rubygems:jekyll:4.2.0'
+ // jekyll dependencies: we cannot use jekyll >=4, as this version uses native lib
+ // ("sassc" instead of deprecated "sass") which fails to compile on some platforms
Review comment:
Wanted to do that, but pressed the commit button too early. Will add the reference to that comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler merged pull request #205: SOLR-15520: Fix build on windows by downgrading jekyll
Posted by GitBox <gi...@apache.org>.
uschindler merged pull request #205:
URL: https://github.com/apache/solr/pull/205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org