You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Bhathiya <no...@github.com> on 2014/10/18 21:29:33 UTC

[jclouds-labs-google] Addressing review suggestions in PR 48 (#61)

I have adressed some of the suggestions from https://github.com/jclouds/jclouds-labs-google/pull/48. There are few more suggestions that need bit more work.
 
You can merge this Pull Request by running:

  git pull https://github.com/hsbhathiya/jclouds-labs-google GCSExamples

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-google/pull/61

-- Commit Summary --

  * Addressing review suggestions in PR 48

-- File Changes --

    M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/GCSBlobStore.java (57)
    M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/BlobMetadataToObjectTemplate.java (3)
    M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/BlobStoreListContainerOptionsToListObjectOptions.java (3)
    M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/ObjectToBlobMetadata.java (3)
    M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/strategy/internal/SequentialMultipartUploadStrategy.java (2)
    M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/GCSObject.java (17)
    M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/ObjectTemplate.java (18)
    M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/fallback/GCSFallbacks.java (3)
    M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/BucketApi.java (2)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/61.patch
https://github.com/jclouds/jclouds-labs-google/pull/61.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/61

Re: [jclouds-labs-google] Addressing review suggestions in PR 48 (#61)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #164](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/164/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/61#issuecomment-59626719

Re: [jclouds-labs-google] Addressing review suggestions in PR 48 (#61)

Posted by Adrian Cole <no...@github.com>.
this drifted a lot! sorry about that. If you feel compelled, you could make a new version of this PR. or not.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/61#issuecomment-61203767

Re: [jclouds-labs-google] Addressing review suggestions in PR 48 (#61)

Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-labs-google #1484](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1484/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/61#issuecomment-59626842